Fix copying of BigInt64Array and BigUint64Array (#452)

laverdet · Jan 24, 2024 · 1598f02 · 1598f02
1 parent be71d25
commit 1598f02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/external_copy/external_copy.cc b/src/external_copy/external_copy.cc
@@ -151,9 +151,9 @@ auto ExternalCopy::Copy(Local<Value> value, bool transfer_out, ArrayRange transf
 		} else if (view->IsFloat64Array()) {
 			type = ViewType::Float64;
 		} else if (view->IsBigInt64Array()) {
-			type = ViewType::BigInt64Array;
+			type = ViewType::BigInt64;
 		} else if (view->IsBigUint64Array()) {
-			type = ViewType::BigUint64Array;
+			type = ViewType::BigUint64;
 		} else if (view->IsDataView()) {
 			type = ViewType::DataView;
 		} else {
@@ -486,6 +486,10 @@ auto NewTypedArrayView(Local<T> buffer, ExternalCopyArrayBufferView::ViewType ty
 			return Float32Array::New(buffer, byte_offset, byte_length >> 2);
 		case ExternalCopyArrayBufferView::ViewType::Float64:
 			return Float64Array::New(buffer, byte_offset, byte_length >> 3);
+		case ExternalCopyArrayBufferView::ViewType::BigInt64:
+			return BigInt64Array::New(buffer, byte_offset, byte_length >> 3);
+		case ExternalCopyArrayBufferView::ViewType::BigUint64:
+			return BigUint64Array::New(buffer, byte_offset, byte_length >> 3);
 		case ExternalCopyArrayBufferView::ViewType::DataView:
 			return DataView::New(buffer, byte_offset, byte_length);
 		default:

diff --git a/src/external_copy/external_copy.h b/src/external_copy/external_copy.h
@@ -102,7 +102,7 @@ class ExternalCopySharedArrayBuffer : public ExternalCopyAnyBuffer {
  */
 class ExternalCopyArrayBufferView : public ExternalCopy {
 	public:
-		enum class ViewType { Uint8, Uint8Clamped, Int8, Uint16, Int16, Uint32, Int32, Float32, Float64, BigInt64Array, BigUint64Array, DataView };
+		enum class ViewType { Uint8, Uint8Clamped, Int8, Uint16, Int16, Uint32, Int32, Float32, Float64, BigInt64, BigUint64, DataView };
 
 	private:
 		std::unique_ptr<ExternalCopyAnyBuffer> buffer;