Improve memory performance for txt chat download (#757)

* Add Quiet Mode. Improve memory performance. * Further reduce allocations --------- Co-authored-by: ScrubN <72096833+ScrubN@users.noreply.github.com>
lay295 · Jul 25, 2023 · ab33c0b · ab33c0b
1 parent ee209a5
commit ab33c0b
Show file tree

Hide file tree

Showing 5 changed files with 187 additions and 110 deletions.
diff --git a/TwitchDownloaderCLI/Modes/Arguments/ChatDownloadArgs.cs b/TwitchDownloaderCLI/Modes/Arguments/ChatDownloadArgs.cs
@@ -40,7 +40,10 @@ public class ChatDownloadArgs
         [Option("chat-connections", Default = 4, HelpText = "Number of downloading connections for chat")]
         public int ChatConnections { get; set; }
 
+        [Option('q', "quiet", Default = false, HelpText = "Suppresses progress console output")]
+        public bool Quiet { get; set; }
+
         [Option("temp-path", Default = "", HelpText = "Path to temporary folder to use for cache.")]
         public string TempFolder { get; set; }
     }
-}
+}
diff --git a/TwitchDownloaderCLI/Modes/DownloadChat.cs b/TwitchDownloaderCLI/Modes/DownloadChat.cs
@@ -61,6 +61,7 @@ private static ChatDownloadOptions GetDownloadOptions(ChatDownloadArgs inputOpti
                 Compression = inputOptions.Compression,
                 TimeFormat = inputOptions.TimeFormat,
                 ConnectionCount = inputOptions.ChatConnections,
+                Quiet = inputOptions.Quiet,
                 BttvEmotes = (bool)inputOptions.BttvEmotes!,
                 FfzEmotes = (bool)inputOptions.FfzEmotes!,
                 StvEmotes = (bool)inputOptions.StvEmotes!,

diff --git a/TwitchDownloaderCore/Chat/ChatText.cs b/TwitchDownloaderCore/Chat/ChatText.cs
@@ -24,17 +24,17 @@ public static async Task SerializeAsync(string filePath, ChatRoot chatRoot, Time
             await using var sw = new StreamWriter(filePath);
             foreach (var comment in chatRoot.comments)
             {
-                string username = comment.commenter.display_name;
-                string message = comment.message.body;
+                var username = comment.commenter.display_name;
+                var message = comment.message.body;
                 if (timeFormat == TimestampFormat.Utc)
                 {
-                    var timestamp = comment.created_at.ToString("yyyy'-'MM'-'dd HH':'mm':'ss 'UTC'");;
-                    await sw.WriteLineAsync($"[{timestamp}] {username}: {message}");
+                    var timestamp = comment.created_at;
+                    await sw.WriteLineAsync($"[{timestamp:yyyy'-'MM'-'dd HH':'mm':'ss 'UTC'}] {username}: {message}");
                 }
                 else if (timeFormat == TimestampFormat.UtcFull)
                 {
-                    var timestamp = comment.created_at.ToString("yyyy'-'MM'-'dd HH':'mm':'ss.fff 'UTC'");;
-                    await sw.WriteLineAsync($"[{timestamp}] {username}: {message}");
+                    var timestamp = comment.created_at;
+                    await sw.WriteLineAsync($"[{timestamp:yyyy'-'MM'-'dd HH':'mm':'ss.fff 'UTC'}] {username}: {message}");
                 }
                 else if (timeFormat == TimestampFormat.Relative)
                 {