Add buttons for reordering tasks (#1200)

* Add buttons and logic for rearranging tasks * Use FontAwesome for close button * Fix potential race condition
lay295 · Aug 29, 2024 · c878915 · c878915
1 parent 4bcb917
commit c878915
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 3 deletions.
diff --git a/TwitchDownloaderWPF/PageQueue.xaml b/TwitchDownloaderWPF/PageQueue.xaml
@@ -87,7 +87,17 @@
                                             <Image MaxHeight="20" Margin="5,0" gif:ImageBehavior.AnimatedSource="{Binding StatusImage, Mode=OneWay, NotifyOnSourceUpdated=True, UpdateSourceTrigger=PropertyChanged}" />
                                         </StackPanel>
                                     </StackPanel>
-                                    <Button Grid.Column="2" Padding="7, 0" VerticalAlignment="Top" Height="24" FontSize="12" Content="X" Click="BtnRemoveTask_Click" Background="{DynamicResource AppElementBackground}" Foreground="{DynamicResource AppTextDisabled}" BorderBrush="{DynamicResource AppElementBorder}" />
+                                    <StackPanel Grid.Column="2" Orientation="Horizontal">
+                                        <Button Padding="0" VerticalAlignment="Top" Width="22" Height="22" Margin="0, 0, 2, 0" Click="BtnMoveTaskUp_Click" Background="{DynamicResource AppElementBackground}" BorderBrush="{DynamicResource AppElementBorder}">
+                                            <fa:SvgAwesome Icon="Solid_CaretUp" Foreground="{DynamicResource AppTextDisabled}" />
+                                        </Button>
+                                        <Button Padding="0" VerticalAlignment="Top" Width="22" Height="22" Margin="0, 0, 2, 0" Click="BtnMoveTaskDown_Click" Background="{DynamicResource AppElementBackground}" BorderBrush="{DynamicResource AppElementBorder}">
+                                            <fa:SvgAwesome Icon="Solid_CaretDown" Foreground="{DynamicResource AppTextDisabled}" />
+                                        </Button>
+                                        <Button Padding="3" VerticalAlignment="Top" Width="22" Height="22" FontSize="12" Click="BtnRemoveTask_Click" Background="{DynamicResource AppElementBackground}" Foreground="{DynamicResource AppTextDisabled}" BorderBrush="{DynamicResource AppElementBorder}">
+                                            <fa:SvgAwesome Icon="Solid_Times" Foreground="{DynamicResource AppTextDisabled}" />
+                                        </Button>
+                                    </StackPanel>
                                 </Grid>
                             </Border>
                         </DataTemplate>

diff --git a/TwitchDownloaderWPF/PageQueue.xaml.cs b/TwitchDownloaderWPF/PageQueue.xaml.cs
@@ -290,9 +290,12 @@ private static void RemoveTask(TwitchTask task)
                 return;
             }
 
-            if (!taskList.Remove(task))
+            lock (taskLock)
             {
-                MessageBox.Show(Application.Current.MainWindow!, Translations.Strings.TaskCouldNotBeRemoved, Translations.Strings.UnknownErrorOccurred, MessageBoxButton.OK, MessageBoxImage.Error);
+                if (!taskList.Remove(task))
+                {
+                    MessageBox.Show(Application.Current.MainWindow!, Translations.Strings.TaskCouldNotBeRemoved, Translations.Strings.UnknownErrorOccurred, MessageBoxButton.OK, MessageBoxImage.Error);
+                }
             }
         }
 
@@ -333,5 +336,39 @@ private static void RetryTask(TwitchTask task)
                 task.Reinitialize();
             }
         }
+
+        private void BtnMoveTaskUp_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not Button { DataContext: TwitchTask task })
+            {
+                return;
+            }
+
+            lock (taskLock)
+            {
+                var index = taskList.IndexOf(task);
+                if (index < 1)
+                    return;
+
+                taskList.Move(index, index - 1);
+            }
+        }
+
+        private void BtnMoveTaskDown_Click(object sender, RoutedEventArgs e)
+        {
+            if (sender is not Button { DataContext: TwitchTask task })
+            {
+                return;
+            }
+
+            lock (taskLock)
+            {
+                var index = taskList.IndexOf(task);
+                if (index == -1 || index == taskList.Count - 1)
+                    return;
+
+                taskList.Move(index, index + 1);
+            }
+        }
     }
 }