Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better legacy chat support #960

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Better legacy chat support #960

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
100f894
Smarter broadcaster id assumption
ScrubN Jan 28, 2024
7322d59
Recover video id and broadcast date/time if possible
ScrubN Jan 28, 2024
f226d0f
Cleanup
ScrubN Jan 28, 2024
b4b9614
Prevent throwing on bad int string parse, add additional name assumpt…
ScrubN Jan 28, 2024
54ed31a
Oops
ScrubN Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions TwitchDownloaderCore/Chat/ChatJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,37 @@ private static async Task<JsonDocument> GetJsonDocumentAsync(Stream stream, stri
private static async Task UpgradeChatJson(ChatRoot chatRoot)
{
const int MAX_STREAM_LENGTH = 172_800; // 48 hours in seconds. https://help.twitch.tv/s/article/broadcast-guidelines

var firstComment = chatRoot.comments.FirstOrDefault();
var lastComment = chatRoot.comments.LastOrDefault();

chatRoot.video ??= new Video
{
start = (int)Math.Floor(chatRoot.comments.FirstOrDefault()?.content_offset_seconds ?? 0),
end = (int)Math.Ceiling(chatRoot.comments.LastOrDefault()?.content_offset_seconds ?? MAX_STREAM_LENGTH)
start = (int)Math.Floor(firstComment?.content_offset_seconds ?? 0),
end = (int)Math.Ceiling(lastComment?.content_offset_seconds ?? MAX_STREAM_LENGTH)
};

chatRoot.video.id ??= firstComment?.content_id;

if (chatRoot.video.created_at == default)
chatRoot.video.created_at = firstComment?.created_at - TimeSpan.FromSeconds(firstComment?.content_offset_seconds ?? 0) ?? default;

if (chatRoot.streamer is null)
{
var assumedId = int.Parse(chatRoot.video.user_id ?? chatRoot.comments.FirstOrDefault()?.channel_id ?? "0");
var assumedName = chatRoot.video.user_name ?? await TwitchHelper.GetStreamerName(assumedId);
var broadcaster = new Lazy<Comment>(() =>
chatRoot.comments
.Where(x => x.message.user_badges != null)
.FirstOrDefault(x => x.message.user_badges.Any(b => b._id.Equals("broadcaster"))));

if (!int.TryParse(chatRoot.video.user_id, out var assumedId))
{
if (!int.TryParse(broadcaster.Value?.commenter._id, out assumedId))
{
assumedId = 0;
}
}

var assumedName = chatRoot.video.user_name ?? broadcaster.Value?.commenter.display_name ?? await TwitchHelper.GetStreamerName(assumedId);

chatRoot.streamer = new Streamer { id = assumedId, name = assumedName };
}
Expand Down
Loading