New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of handle_request is easy to misinterpret. #5

Closed

bddap opened this issue Apr 23, 2019 · 0 comments

Contributor

bddap commented Apr 23, 2019

handle_request should not return an option. Option::None may be interpreted as an error.

mimblewimble/grin-wallet#88

Solution

Return a custom enum from handle_request:

pub enum HandleResponse {
    Call(Value),
    Notification,
}

bddap closed this as completed in

4e6569f

bddap added a commit that referenced this issue


          Merge pull request #6 from layer1capital/5

2336bbc

fix #5

bddap mentioned this issue

fix #88 mimblewimble/grin-wallet#89

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment