[Checkbox Group] Track Option Item state changes
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTAndrew
force-pushed
the
akl_track_item_state_changes_on_checkbox_group
branch
from
a13bf4c
to
6fd294a
Compare
ickas
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
CheckboxGroupcomponent is a list ofCheckboxcomponents, currently it is not possible to track the state of each item because:CheckboxGroup onChangeis badly typedCheckboxItem onChangeis not being usedNow, it's possible to track the changes both from the
CheckboxGroup and CheckboxItem, leaving the choice to the developer.