Add support for CALayer layout #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucdion
reviewed
Jun 21, 2018
| @@ -415,8 +408,8 @@ class PinSafeAreaMoreTestsSpec: QuickSpec { | |||
| setupWindow(with: navigationController) | |||
|
|
|||
| // MATCH safeAreaInsets! | |||
| expect(mainView.safeAreaInsetsDidChangeCalledCount).to(equal(expectedSafeAreaInsetsDidChangeCalledCount)) | |||
| expect(mainView.subView.safeAreaInsetsDidChangeCalledCount).to(equal(expectedSubViewSafeAreaInsetsDidChangeCalledCount)) | |||
| expect(mainView.safeAreaInsetsDidChangeCalledCount) > 0 | |||
There was a problem hiding this comment.
We could also update all other similar cases in safeArea unit tests.
lucdion
reviewed
Jun 21, 2018
Tests/Common/CALayerSpec.swift
Outdated
| aLayer.pin.top(10).left(10).width(20%).height(80%).layout() | ||
| bLayer.pin.size(CGSize(width: 20, height: 20)).right(of: aLayer, aligned: .center).layout() | ||
| expect(aLayer.frame).to(equal(CGRect(x: 10, y: 10, width: 80, height: 320))) | ||
| } |
There was a problem hiding this comment.
maybe add unit tests that:
- use
pinFrame - use
edgeproperty - use
anchorproperty
There was a problem hiding this comment.
Will also do :)
lucdion
reviewed
Jun 21, 2018
Tests/Common/CALayerSpec.swift
Outdated
| // | ||
| describe("test CALayer interface") { | ||
| it("basic pinlayout calls") { | ||
| aLayer.pin.top(10).left(10).width(20%).height(80%).layout() |
There was a problem hiding this comment.
Is it required to call layout()?
There was a problem hiding this comment.
Not sure, I took example on the ObjectiveCSpec that also manually call layout() but it is most likely not needed.
…ll instead of an exact number of calls
lucdion
reviewed
Jun 26, 2018
| * [`aspectRatio()`](#aspect_ratio) with no parameters (Coming soon) | ||
|
|
||
| * Support for [`sizeToFit(:FitType)`](#sizeToFit) can be added to your custom NSView subclasses. Just make those views conform to the `SizeCalculable` protocol and implement the two required functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since every UIView has a backing layer and it's that layer's responsibility alone to manage coordinates and drawing, I added Layoutable conformance to CALayer and delegated UIView's getRect/setRect to it's backing layer. NSView is a slightly different animal and it's not all NSView that has a backing layer so we leave it's current layout system unchanged.