This repository has been archived by the owner on May 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Give option to not override files #18
Open
dluxemburg
wants to merge
1
commit into
lazd:master
Choose a base branch
from
dluxemburg:toggle-override-files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #9. |
Okay, will comment there. Any chance of landing this though as a simple fix? Seems like a number of users are affected. |
👍 Would love to see this merged! |
👍 |
👍 .... bueller |
@blittle @nmccready @sfarthin, stay tuned over at karma-runner/karma#1037 for a better solution for gulp + karma integration. |
thank you |
I forked it for the time being with the @dluxemburg changes merged to my master |
@nmccready, you can target specific commit hashes in your package.json and use forks/branches, btw: https://www.npmjs.org/doc/json.html#Git-URLs-as-Dependencies |
Oh cool, well for the time-being this is safer for my work. We need to stand up a node repository, and a private bower repo. |
Any updates on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for situations in which overriding Karma's file list will break a test suite (such as when using RequireJS and the no-include file option). It's a minimal change that has no impact on behavior when the feature isn't opted in to.