Direct reacting from notifications #6935
Conversation
rafael-xmr
force-pushed
the
notifications_reacts
branch
from
1da2652
to
de71a45
Compare
rafael-xmr
force-pushed
the
notifications_reacts
branch
from
de71a45
to
124a41e
Compare
| <div | ||
| className={classnames('notification__wrapper', { | ||
| 'notification__wrapper--unread': !is_read, | ||
| })} | ||
| > | ||
| <Wrapper> |
There was a problem hiding this comment.
Lots of console errors
There was a problem hiding this comment.
This one still exists. Can ship, although we should stop introducing console errors to a already-long list (e.g. Modal dismissal, Reach, videojs)
| @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Add confirmation on comment removal _community pr!_ ([#6563](https://github.com/lbryio/lbry-desktop/pull/6563)) | |||
| - Show on content page if a file is part of a playlist already _community pr!_([#6393](https://github.com/lbryio/lbry-desktop/pull/6393)) | |||
| - Add filtering to playlists ([#6905](https://github.com/lbryio/lbry-desktop/pull/6905)) | |||
| - Added direct replying to notifications _community pr!_ ([#6935](https://github.com/lbryio/lbry-desktop/pull/6935)) | |||
There was a problem hiding this comment.
File thumbnail flickers a lot
Probably a non-blocker, but a bit annoying. Was present in the past, but now super obvious.
It flickers when:
- you refresh the Notifications Page (or initial load)
- On a comment notification, click "Reply" to expand the text box (notice other notifications with file thumbnails will flicker).
- On a comment notification, click "Cancel" to close the text box (notice other notifications with file thumbnails will flicker).
There was a problem hiding this comment.
[Non-blocker] Unknown error
Not sure how to reproduce this. Happens only on a few notifications when replying.
There was a problem hiding this comment.
Ah, it happens when the actual comment has been deleted. Not sure how to handle this gracefully. Probably can ignore for now, unless you have some ideas.
There was a problem hiding this comment.
challenge accepted
There was a problem hiding this comment.
@infinite-persistence if this looks good on another review, please merge
rafael-xmr
force-pushed
the
notifications_reacts
branch
2 times, most recently
from
944c662
to
ead363c
Compare
infinite-persistence
force-pushed
the
notifications_reacts
branch
from
ead363c
to
b69b01e
Compare
Fixes
Issue Number: #5062, and closes #6906
(Previously #6711, now with issues addressed)
What is the new behavior?
PR Type & Checklist
PR Type...
What kind of change does this PR introduce?
PR Checklist...
Please check all that apply to this PR using "x":