Prevent .deb packages from being opened with archive manager. #7502

Ruk33 · 2022-03-03T01:12:07Z

Fixes

Issue Number: #7495

What is the current behavior?

With Ubuntu >= 20 .deb packages are opened with archive explorer.

What is the new behavior?

.deb packages are properly installed and the app relaunches when the installation finishes.

^ if there is an error (ie, incorrect password or permission wasn't granted), we let the user know.

When the installation finishes, the app will relaunch automatically.

Other information

How to test

From /lbry-desktop/ui/redux/actions/app.js, replace lines 218:224 with:

      // if (
      //   upgradeAvailable &&
      //   !selectModal(state) &&
      //   (!selectIsUpgradeSkipped(state) || remoteVersion !== selectRemoteVersion(state))
      // ) {
      //   dispatch(doOpenModal(MODALS.UPGRADE));
      // }
      dispatch(doOpenModal(MODALS.UPGRADE));

And update line 213 with:

      dispatch({
        type: ACTIONS.CHECK_UPGRADE_SUCCESS,
        data: {
          upgradeAvailable: true, // <- here
          remoteVersion,
        },
      });

Run yarn build
Install deb package from /lbry-desktop/dist/electron
Open up the recent installed version with lbry

PR Checklist

Toggle...

What kind of change does this PR introduce?

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

jessopb · 2022-03-03T23:24:35Z

Good progress. I can still get into double downloads. Flow feels good otherwise.

Ruk33 · 2022-03-04T15:02:58Z

Thank you @jessopb for the review. I have sent a fix for it.

jessopb · 2022-03-07T13:46:12Z

I tested this on linux by yarn build this branch after changing the version in package.json to 0.52.4. Then installing that build from the .deb.
Unfortunately, it's throwing an error looking for app-update.yml when lbry is launched from console and never shows the update available notifications. It does provide, in help page, the suggestion to download the lastest version which navigates the user to the download website.
To confirm it was this branch, I built master locally in the same way, with version set to 0.52.4 as well, and the update notifications and nags were present in that case. And there were no console complaints about app-update.yml
It doesn't look to me like something in this pr could change that, but it does ???

Ruk33 · 2022-03-14T13:43:26Z

Hello @jessopb. I'm pretty sure the error you are facing isn't coming from this PR but for this: https://github.com/lbryio/lbry-desktop/pull/7492/files#diff-9e864f33e9f6d8e9a52d5df4de9861f47a3a45222f1f8fb620acd9c37193bb12R198
Notice how we previously, for .deb installations, we check for updates using Native.getAppVersionInfo().then(success, fail); but after the change, it always uses the ipcRenderer.send('check-for-updates', ...) call.

Ruk33 · 2022-03-14T14:03:23Z

To prevent having this error, you can create the following file app-update.yml in /opt/LBRY/resources

owner: lbryio
repo: lbry-desktop
provider: github

And re-open the app. With that, the error no longer shows up:

Ruk33 · 2022-03-21T13:55:56Z

Hello, is there anything I need to update in this pr? Please let me know, happy to update if required. Thanks.

jessopb · 2022-03-23T19:34:32Z

This may be the right track, but I'm not sure how this is a solution fit for production. The problem is not only the console error, but also the lack of update notification in the app, which did not happen before, if I recall correctly.
#7502 (comment)

Perhaps the solution is this sort of file copy? https://www.electron.build/configuration/contents#extraresources

Ruk33 · 2022-06-22T02:56:28Z

@jessopb I have sent an update for the missing app-update.yml. After reading, it seems like just adding it as a additional resource is the best option. Will keep testing tomorrow to make sure everything is ok.

jessopb · 2022-06-22T21:21:14Z

I'm seeing windows misreporting the title of the prerelease as a release, though it upgrades properly.
I'm seeing deb misreporting the release instead of prerelease in the "begin upgrade" modal sudo... [release].deb
Also, closing the upgrade modal (reexposing the nag) and opening it again reinitiates the download.

…ads.

jessopb · 2022-07-07T20:38:27Z

I'm going to merge this anyways, but:

Couple small bugs for .deb -
Flood of these while downloading

Function provided here: ui.js:2:3954536

Attempting to call a function in a renderer window that has been closed or released.

And, after cancelling download and restarting, progress bar is back at 0 and titled "Downloading Update" (but not making progress). The modal is otherwise ready to upgrade.

Otherwise, the sudo-prompt worked very well.

jessopb · 2022-07-07T20:42:05Z

ui/component/lastReleaseChanges/view.jsx

@@ -35,7 +36,7 @@ const LastReleaseChanges = (props: Props) => {
  );

  useEffect(() => {
-    const lastReleaseUrl = 'https://api.github.com/repos/lbryio/lbry-desktop/releases/latest';
+    const lastReleaseUrl = `https://api.github.com/repos/lbryio/lbry-desktop/releases/tags/${releaseVersion}`;


There's also something strange that happened - I pushed a tag with 'alpha' in it which ended up on top of the list, but there were no builds associated with it (also, the tag erroneously was nested in "", so updates were failing. Probably some library code that just gets the last tag with a prerelease keyword in it. After I deleted the bad tag, it was fine.

jessopb · 2022-07-07T20:45:54Z

package.json

@@ -67,6 +67,7 @@
    "remove-markdown": "^0.3.0",
    "rss": "^1.2.2",
    "source-map-explorer": "^2.5.2",
+    "sudo-prompt": "^9.2.1",


This repository is archived on github. Something to keep an eye on, or fork for our selves.

jessopb · 2022-07-07T20:47:30Z

ui/redux/selectors/app.js

+      // When downloading, we need to remove the initial
+      // v, ending up with a file name like
+      // LBRY_0.53.5-alpha.test7495b.deb
+      const fileName = 'LBRY_' + (releaseVersion || '').replace('v', '') + '.deb';


This could maybe use some error catching/validation. It's fine though.

jessopb · 2022-07-07T20:49:36Z

frodo after the thing is done

Ruk33 force-pushed the 7495-deb-update-fails-to-launch-on-ubuntu branch from 522ce7a to d4b8c9c Compare March 4, 2022 21:00

Ruk33 force-pushed the 7495-deb-update-fails-to-launch-on-ubuntu branch from 386d9d0 to 4b922d4 Compare June 22, 2022 02:55

Ruk33 added 11 commits July 6, 2022 18:15

Prevent .deb packages from being opened with archive manager.

55b20a8

Allow to properly cancel download upgrade and prevent multiple downlo…

412a0c2

…ads.

Fix missing app-update.yml file for .deb builds.

0476a54

Small fix for allowPrerelease prop in autoUpdater.

207a1ad

Use release/tags endpoint to get the release details.

7a6ca51

Handle error case for auto updater.

063fd8f

Make install now button display the upgrade modal.

f82231c

Use GitHub as provider for manual update url.

5386ec1

Small fixes in updater.

d3ed068

Fix small lint errors.

620126d

Properly handle auto download on/off.

f46d008

Ruk33 force-pushed the 7495-deb-update-fails-to-launch-on-ubuntu branch from b938d31 to f46d008 Compare July 6, 2022 21:15

jessopb reviewed Jul 7, 2022

View reviewed changes

jessopb merged commit f065218 into master Jul 7, 2022

jessopb deleted the 7495-deb-update-fails-to-launch-on-ubuntu branch July 7, 2022 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent .deb packages from being opened with archive manager. #7502

Prevent .deb packages from being opened with archive manager. #7502

Ruk33 commented Mar 3, 2022 •

edited

Loading

jessopb commented Mar 3, 2022

Ruk33 commented Mar 4, 2022

jessopb commented Mar 7, 2022

Ruk33 commented Mar 14, 2022 •

edited

Loading

Ruk33 commented Mar 14, 2022

Ruk33 commented Mar 21, 2022

jessopb commented Mar 23, 2022

Ruk33 commented Jun 22, 2022

jessopb commented Jun 22, 2022 •

edited

Loading

jessopb commented Jul 7, 2022

jessopb Jul 7, 2022 •

edited

Loading

jessopb Jul 7, 2022

jessopb Jul 7, 2022

jessopb commented Jul 7, 2022 •

edited

Loading

Prevent .deb packages from being opened with archive manager. #7502

Prevent .deb packages from being opened with archive manager. #7502

Conversation

Ruk33 commented Mar 3, 2022 • edited Loading

Fixes

What is the current behavior?

What is the new behavior?

Other information

How to test

PR Checklist

jessopb commented Mar 3, 2022

Ruk33 commented Mar 4, 2022

jessopb commented Mar 7, 2022

Ruk33 commented Mar 14, 2022 • edited Loading

Ruk33 commented Mar 14, 2022

Ruk33 commented Mar 21, 2022

jessopb commented Mar 23, 2022

Ruk33 commented Jun 22, 2022

jessopb commented Jun 22, 2022 • edited Loading

jessopb commented Jul 7, 2022

jessopb Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

jessopb Jul 7, 2022

Choose a reason for hiding this comment

jessopb Jul 7, 2022

Choose a reason for hiding this comment

jessopb commented Jul 7, 2022 • edited Loading

Ruk33 commented Mar 3, 2022 •

edited

Loading

Ruk33 commented Mar 14, 2022 •

edited

Loading

jessopb commented Jun 22, 2022 •

edited

Loading

jessopb Jul 7, 2022 •

edited

Loading

jessopb commented Jul 7, 2022 •

edited

Loading