add hosting to first run #7598
Merged
add hosting to first run #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jessopb
commented
Jun 1, 2022
•
jessopb
commented
- adds simple and advanced data hosting pages to first run
- adds blob storage visualization
- adds new content hosting section to settings
- enables 'auto' hosting
- simplifies and improves styling on hosting settings
- fixes 'claimId' parseUrl deprecation warnings
jessopb
force-pushed
the
feat-autoHosting-and-firstRun
branch
from
6770f9f
to
fca62f9
Compare
kauffj
reviewed
Jun 2, 2022
There was a problem hiding this comment.
mostly minor feedback
also some concern about storage state / variable state of disk sizing (would storing all disk values as number of bytes rather than strings be better? would it be better to have a boolean variable representing unlimited?), but not strongly held
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.