fix hover style for char count field

[ByronEricPerez]

Fixes

Issue Number: #7564

What is the current behavior?

What is the new behavior?

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting)
• Refactoring (no functional changes)
• Documentation changes
• Other - Please describe:

Please check all that apply to this PR using "x":

• I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
• I added a line describing my change to CHANGELOG.md
• I have checked that this PR does not introduce a breaking change
• This PR introduces breaking changes and I have provided a detailed explanation below

[jessopb]

thanks! I'll take a look.

[ByronEricPerez]

Hi @jessopb all good with this, do you need me to change something?

[jessopb]

I think this would be cleaner if it weren't class "button--file-action". It's not completely clear what file-action is, but this is a comment action or something. I think it deserves its own class. button--comment-icons, perhaps.

[ByronEricPerez]

Hello, @jessopb I have already sent the changes, is this ok?

[jessopb]

@ByronEricPerez I think it just needs a clean class that takes the place of button--file-actions because it's not a "file-action".

[ByronEricPerez]

Hello @jessopb , it is not entirely clear to me, would it be to rename the class?

[jessopb]

this should not need button--file-action
One class should be sufficient to specify what this should look like.
button--comment-icons should contain all that it needs.

[ByronEricPerez]

Hi @jessopb , would that be ok?

[jessopb]

Yeah, this is better. Just a couple more comments.

[jessopb]

If you look in the code for button--file-action-active, you'll see that it's used like this:

<Button
        title={__('I like this')}
        authSrc="filereaction_like"
        className={classnames('button--file-action button-like', {
          'button--file-action-active': myReaction === REACTION_TYPES.LIKE,
        })}

It does not seem that button--comment-icons-active is used anywhere - I'm not sure it's necessary.

[jessopb]

This looks good!