Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkbox to enable/disable background #7630

Conversation

ByronEricPerez
Copy link
Contributor

@ByronEricPerez ByronEricPerez commented Jun 28, 2022

Fixes

Issue Number: #7616

What is the current behavior?

N/A

What is the new behavior?

image

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. Just a couple things.

return (
<>
<div
className={'background-image'}
style={{
backgroundImage: `url(${freeezepeach})`,
backgroundImage: background ? `none` : `url(${freeezepeach})`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this backwards?

@@ -20,7 +21,7 @@ type Props = {
};

export default function SettingAppearance(props: Props) {
const { clock24h, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props;
const { clock24h, background, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could call this showBackground to imply its bool type

ui/component/wallpaper/index.js Show resolved Hide resolved
Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good - thanks!

@jessopb jessopb merged commit f79c622 into lbryio:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants