-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checkbox to enable/disable background #7630
Added checkbox to enable/disable background #7630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work. Just a couple things.
ui/component/wallpaper/view.jsx
Outdated
return ( | ||
<> | ||
<div | ||
className={'background-image'} | ||
style={{ | ||
backgroundImage: `url(${freeezepeach})`, | ||
backgroundImage: background ? `none` : `url(${freeezepeach})`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this backwards?
@@ -20,7 +21,7 @@ type Props = { | |||
}; | |||
|
|||
export default function SettingAppearance(props: Props) { | |||
const { clock24h, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props; | |||
const { clock24h, background, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could call this showBackground to imply its bool type
…for background setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good - thanks!
Fixes
Issue Number: #7616
What is the current behavior?
N/A
What is the new behavior?
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":