Properly handle blacklisted claims. #7665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessopb
reviewed
Aug 5, 2022
ui/page/show/view.jsx
Outdated
| <Card | ||
| title={uri} | ||
| subtitle={__( | ||
| 'In response to a complaint we received under the US Digital Millennium Copyright Act, we have blocked access to this content from our applications.' |
There was a problem hiding this comment.
Just need a way to differentiate between actual US DMCA and other reasons. Possibly if blocking channel name includes "DMCA"? This should not be the message for every blocking channel.
Examples of channels here
https://github.com/lbryio/hub/blob/master/docs/blocking.md#defaults
There was a problem hiding this comment.
We hvae a few cases:
- it literally says DMCA in the channel name -> show DMCA text, but say "hub" did it - not "we" did it.
- the channel that blocks it has a description -> some way to show channel and description
- the channel that blocks it has no description. -> some way to show channel and generic text
I think this may need some way to display the channel that blocked (reposted) it, to resolve the channel that blocked it (possibly a claim preview component?) and display the description of the channel that blacked it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: #7663
What is the current behavior?
Blacklisted claims are not being handled properly.
What is the new behavior?
Blacklisted claims (those with
errors.censor) will now bemarked as blacklisted properly.
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":