Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of uploaded files. #7688

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Sep 13, 2022

Fixes

Issue Number:

What is the current behavior?

The behavior when selecting a file is different
than the behavior when it's dragged and dropped.

What is the new behavior?

The behavior when selecting a file and
dropped no longer differs.

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out - after selecting a transcoded video, it still says "your video may not be the best format.

ui/component/fileDrop/view.jsx Show resolved Hide resolved
@jessopb jessopb merged commit 0e2a9a1 into master Sep 19, 2022
@jessopb jessopb deleted the 7687-535-upload-form-bugs branch September 19, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants