support for streams without data: publish without --file_path and then claim search using --has_no_source
#3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackrobison
force-pushed
the
add-no-file-publish
branch
from
1ee591c to
d7e3108
Compare
jackrobison
changed the title
--no_file param to publish, stream_create, and stream_update--no_file_path param to publish, stream_create, and stream_update
shyba
force-pushed
the
add-no-file-publish
branch
2 times, most recently
from
111fc32 to
85509be
Compare
eukreign
requested changes
Mar 12, 2021
lbry/wallet/server/db/writer.py
Outdated
| @@ -55,6 +55,7 @@ class SQLDB: | |||
| description text, | |||
|
|
|||
| claim_type integer, | |||
| no_source bool, | |||
There was a problem hiding this comment.
instead of adding a no_source field, would it be more flexible to add a source field with the actual source, that would have the added benefit of being able to search for claims with particular source?
There was a problem hiding this comment.
source is a dictionary with more than one field right? unless you have one of them in mind.
I like the idea but it would be nice to do this in a way where we don't need one column for each subitem. (something like a flattened field maybe)
lyoshenka
changed the title
--no_file_path param to publish, stream_create, and stream_updatepublish, stream_create, and stream_update work without a file_path argument
shyba
force-pushed
the
add-no-file-publish
branch
from
8d1e3a1 to
5de8493
Compare
eukreign
changed the title
publish, stream_create, and stream_update work without a file_path argumentpublish streams without --file_path and claim search using --no_source
eukreign
changed the title
publish streams without --file_path and claim search using --no_sourcepublish without --file_path and then claim search using --has_no_source
eukreign
force-pushed
the
add-no-file-publish
branch
from
3ee19b0 to
1632d2b
Compare
eukreign
approved these changes
Mar 13, 2021
eukreign
added
area: api
type: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3180