Add all peers when running as a bootstrap node #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
force-pushed
the
bootstrap_node
branch
2 times, most recently
from
c989828 to
631c464
Compare
jackrobison
requested changes
Aug 3, 2022
jackrobison
reviewed
Aug 18, 2022
tests/unit/dht/test_node.py
Outdated
| @@ -11,6 +11,34 @@ | |||
| from lbry.extras.daemon.storage import SQLiteStorage | |||
|
|
|||
|
|
|||
| class TestBootstrapNode(AsyncioTestCase): | |||
| TIMEOUT = 10.0 # do not increase. Hitting a timeout is a real failure | |||
| async def test_it_adds_all(self): | |||
There was a problem hiding this comment.
can this have a more descriptive name?
jackrobison
reviewed
Aug 18, 2022
| peers in the routing table. During bootstrap the shortlist is set to be the seed nodes. | ||
| """ | ||
| if len(key) != constants.HASH_LENGTH: | ||
| raise ValueError("invalid key length: %i" % len(key)) |
There was a problem hiding this comment.
is this dropped intentionally?
There was a problem hiding this comment.
yes, it is checked on the constructor: https://github.com/lbryio/lbry-sdk/pull/3631/files#diff-6cdbfed907d98f6fa01d47ea54cdc27545a13fdcfa817760715c89e9c15d6376R64
(the shortlist comes from the caller now)
jackrobison
approved these changes
Aug 26, 2022
eukreign
added
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3626