Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage payment service more resilient, will continue running until funds available to pay usage fee #3668

Merged
merged 8 commits into from
Sep 20, 2022

Conversation

moodyjon
Copy link
Contributor

@moodyjon moodyjon commented Sep 19, 2022

Fixes #3663

The WalletServerPayer was receiving asyncio.CancelledError from retriable_call() because jsonrpc_wallet_reconnect() creates a situation where the connection is totally gone.

I reworked how it handles exceptions so it tolerates ConnectionError, InsufficientFundsError without exiting prematurely.

Plan to revert 4422896 which is for push button testing.

@coveralls
Copy link

coveralls commented Sep 19, 2022

Coverage Status

Coverage decreased (-0.09%) to 57.728% when pulling 055d5aa on moodyjon:test_single_server_payment into e10f57d on lbryio:master.

@moodyjon moodyjon requested a review from eukreign September 19, 2022 16:28
@lbry-bot lbry-bot assigned eukreign and unassigned moodyjon Sep 19, 2022
@moodyjon moodyjon requested a review from shyba September 19, 2022 16:28
@eukreign
Copy link
Member

i approved this but you have to remove the workflow_dispatch

@eukreign eukreign assigned moodyjon and unassigned shyba Sep 20, 2022
@moodyjon moodyjon force-pushed the test_single_server_payment branch from d82de5e to 13d05d3 Compare September 20, 2022 13:17
@moodyjon
Copy link
Contributor Author

workflow_dispatch removed and exception logging tweaked: 13d05d3

@moodyjon moodyjon requested a review from eukreign September 20, 2022 13:44
@lbry-bot lbry-bot assigned eukreign and unassigned moodyjon Sep 20, 2022
@eukreign eukreign changed the title Fix WalletServerPayer service handling of ConnectionError and others. usage payment service more resilient, will continue running until funds available to pay usage fee Sep 20, 2022
@eukreign eukreign added type: improvement Existing (or partially existing) functionality needs to be changed area: wallet labels Sep 20, 2022
@eukreign eukreign merged commit a7d7efe into lbryio:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: wallet type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_single_server_payment: Timeout waiting on wallet_pay_service.on_payment.first after 30s
4 participants