Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up conditional targets. #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

prenticedavid
Copy link

@prenticedavid prenticedavid commented Apr 22, 2019

dear lcdwiki,

I was asked to check out your library by a SSD1283A owner.
I do not have an SSD1283 but I did test with ILI9341 and ST7735S on Uno, Due, Teensy3.2, ESP32, Nucleo-64 targets.

Conditional register types mean that the same fast Port access statements can be used for "digitalWrite".
I had to move SPI peripheral access from constructor() to begin()
ARM targets can not access peripherals in the constructor because the clocks have not been configured.

Note that the ILI9325 has a different SPI format to ILI9325D.
And ILI9486 uses a different SPIREAD_CMD register and EN bit to the ILI9341.

The SSD1283 owner has gone silent. So the code is untested with SSD1283.
I would have preferred not to open a Pull Request before it was tested.

There is a trivial Pull Request for the LCDWIKI_gui

David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant