Create header-only link target lcm-coretypes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new exported INTERFACE library, lcm-coretypes, which provides users a way to depend on the LCM headers without needing to link to the actual LCM library. LCM types libraries will likely want to "link" to this. (In particular, C++ LCM types "libraries" are header-only with an include dependency on LCM but no link dependency. Consumers of these "libraries" need the LCM include directories, but may not need to link to the actual LCM library. The interface library gives consumers a way to make this work, conveniently.)
mojasp
pushed a commit
to Barkhausen-Institut/lcm-sec
that referenced
this pull request
May 23, 2022
…ace-library Create header-only link target lcm-coretypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new exported
INTERFACElibrary,lcm-coretypes, which provides users a way to depend on the LCM headers without needing to link to the actual LCM library. LCM types libraries will likely want to "link" to this.(In particular, C++ LCM types "libraries" are header-only with an include dependency on LCM but no link dependency. Consumers of these "libraries" need the LCM include directories, but may not need to link to the actual LCM library. The interface library gives consumers a way to make this work, conveniently.)