Dftatom: Changes from lfortran LibASR #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Sep 22, 2023
| ASR::dimension_t* m_dims; | ||
| int n_dims = ASRUtils::extract_dimensions_from_ttype(x_mv_type, m_dims); | ||
| bool is_data_only_array = ASRUtils::is_fixed_size_array(m_dims, n_dims) && ASRUtils::get_asr_owner(arr_expr) && | ||
| ASR::is_a<ASR::StructType_t>(*ASRUtils::get_asr_owner(arr_expr)); |
There was a problem hiding this comment.
Does "data only array" in this context mean "FixedSizeArray" inside a struct?
There was a problem hiding this comment.
Ok. I would maybe document this in a comment, or maybe name the variable fixed_array_inside_struct, or something like that.
| @@ -698,8 +698,7 @@ static inline ASR::symbol_t *get_asr_owner(const ASR::expr_t *expr) { | |||
| return ASRUtils::get_asr_owner(ASR::down_cast<ASR::FunctionCall_t>(expr)->m_name); | |||
| } | |||
| default: { | |||
| throw LCompilersException("Cannot find the ASR owner of underlying symbol of expression " | |||
| + std::to_string(expr->type)); | |||
| return nullptr; | |||
There was a problem hiding this comment.
Note: this changes the API, now it will return nullptr if the node does not have an ASR owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related lfortran/lfortran#2488