Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting assignment through basic_assign #2378

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Supporting assignment through basic_assign #2378

merged 2 commits into from
Oct 9, 2023

Conversation

anutosh491
Copy link
Collaborator

Addressing comment (#2368 (comment)).
Now all variable to variable assignments take place through basic_assign as recommended by symengine's documentation.

@anutosh491
Copy link
Collaborator Author

We won't really need some heavy testing here as we already had assignment working through the default = operator. I've still added a simple case in symbolics_01.py

certik
certik approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks!

@certik certik merged commit 013df0c into lcompilers:main Oct 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
symbolic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anutosh491 @certik @Thirumalai-Shaktivel