refactor: check for dependency only in parent scope #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arteevraina This looks good. Can you send this PR against LFortran too, to ensure everything works there? After that we can merge. |
Sure. |
2 tasks
|
Let's merge the LFortran first, then we can merge this one. For LFortran, see here: lfortran/lfortran#2798 (comment). |
|
@certik Can we now merge this as well ? |
certik
force-pushed
the
asr-verify-update
branch
from
bb05b29
to
c487d20
Compare
|
Yes, I think this is good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2392