Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Punctuation mistake in error message #2407

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix: Punctuation mistake in error message #2407

merged 1 commit into from
Nov 2, 2023

Conversation

pnc009
Copy link
Contributor

@pnc009 pnc009 commented Nov 2, 2023

anutosh491
anutosh491 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
Thanks

certik
certik approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix! This is correct.

All our error messages can definitely be greatly improved.

@certik certik merged commit c21c0e3 into lcompilers:main Nov 2, 2023
13 checks passed
@pnc009 pnc009 deleted the fix/error-message branch November 2, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@anutosh491 anutosh491 anutosh491 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Punctuation mistake in error message
3 participants
@pnc009 @certik @anutosh491