CI: switch to micromamba #2758
Closed
CI: switch to micromamba #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's weird that I had to fix a xonsh version. I think it's because old versions of packages were being cached, and the new versions do not work. The macOS error might also be caused by that. I am investigating just this cache issue in #2759. |
certik
commented
Jul 6, 2024
.github/workflows/CI.yml
Outdated
|
|
||
| - name: Install Linux / macOS Conda Packages | ||
| if: contains(matrix.os, 'ubuntu') || contains(matrix.os, 'macos') | ||
| shell: bash -e -l {0} | ||
| run: conda install bison=3.4 nodejs=18 | ||
| run: micromamba install bison=3.4 nodejs=18 xeus=1.0.1 nlohmann_json=3.9.1 |
There was a problem hiding this comment.
For some reason this line upgrades packages, destroying our "pins" from ci/environment.yml. We need to make micromamba to only install the new packages, without upgrading.
|
Failing macOS: Working macOS: |
|
Failing versions: good versions: |
|
Here are the packages in conda info, there are still some slight differences: |
|
@Vipul-Cariappa this PR is now pretty minimal. The switch to micromamba makes the macOS test fail. We have to compare package versions, there are still some differences, although quite minor now. All the major packages are now the same. |
Closed
|
I believe -1 in 8 bits would be represented as |
|
@certik, I don't have a macOS based computer, could you please try this and give me the output in interactive mode. >>> i8(-1)
-1 |
|
I don't have a macOS either right now. I commented out the failing tests, let's see if this is the only issue. |
|
@Vipul-Cariappa everything passes finally. I am now testing these changes in your jupyter PR: #2763. |
|
Fixed in #2764. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.