-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value for vector type input parameters #116
Add default value for vector type input parameters #116
Conversation
5c0c1eb
to
7e26327
Compare
7e26327
to
352882e
Compare
Pinging @smpeyres @dcurreli for review. This is necessary for the MOOSE PR mentioned in @MengnanLi91's message above to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiles & tests successfully, but compilation gives warning for line 904 in ChemicalReactionsBase.C regarding unused label ‘std’ [-Wunused-label] for std:string error_str
Thanks for the review. I've removed the unused label and tested compiling |
Thanks for the quick change! Compiles without warning and tests pass. Waiting to merge until CI is online for CRANE. |
@MengnanLi91 if you rebase on top of CRANE devel, this should pass precheck testing. I can then activate testing for you. |
Thanks Casey! I'll rebase and tag you to activate the testing. |
0169c6e
to
7122fd8
Compare
7122fd8
to
7da886d
Compare
@cticenhour Could you help me with testing? |
@smpeyres This is passing testing and is ready to be merged. See https://civet.inl.gov/pr/19853/. |
Bug Description
Refer to the issue #24455, a fix is introduced to MOOSE to properly report error when no default value is provided for vector type input parameter. This new fix in MOOSE cause several tests failed in Crane which don't provide default value for vector parameter.
Impact
This patch is made to fix the failed Crane tests due to the new changes in MOOSE