Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for vector type input parameters #116

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

MengnanLi91
Copy link
Contributor

Bug Description

Refer to the issue #24455, a fix is introduced to MOOSE to properly report error when no default value is provided for vector type input parameter. This new fix in MOOSE cause several tests failed in Crane which don't provide default value for vector parameter.

Impact

This patch is made to fix the failed Crane tests due to the new changes in MOOSE

@MengnanLi91 MengnanLi91 force-pushed the input_vector_parameter_fix branch from 5c0c1eb to 7e26327 Compare September 27, 2023 21:13
MengnanLi91 added a commit to MengnanLi91/crane that referenced this pull request Sep 27, 2023
@MengnanLi91 MengnanLi91 force-pushed the input_vector_parameter_fix branch from 7e26327 to 352882e Compare September 27, 2023 21:13
@MengnanLi91 MengnanLi91 marked this pull request as ready for review September 27, 2023 21:14
@cticenhour
Copy link
Collaborator

Pinging @smpeyres @dcurreli for review. This is necessary for the MOOSE PR mentioned in @MengnanLi91's message above to be merged.

Copy link
Collaborator

@smpeyres smpeyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles & tests successfully, but compilation gives warning for line 904 in ChemicalReactionsBase.C regarding unused label ‘std’ [-Wunused-label] for std:string error_str

@MengnanLi91
Copy link
Contributor Author

MengnanLi91 commented Oct 3, 2023

Compiles & tests successfully, but compilation gives warning for line 904 in ChemicalReactionsBase.C regarding unused label ‘std’ [-Wunused-label] for std:string error_str

Thanks for the review. I've removed the unused label and tested compiling

@smpeyres
Copy link
Collaborator

smpeyres commented Oct 3, 2023

Thanks for the quick change! Compiles without warning and tests pass. Waiting to merge until CI is online for CRANE.

@cticenhour
Copy link
Collaborator

@MengnanLi91 if you rebase on top of CRANE devel, this should pass precheck testing. I can then activate testing for you.

@MengnanLi91
Copy link
Contributor Author

@MengnanLi91 if you rebase on top of CRANE devel, this should pass precheck testing. I can then activate testing for you.

Thanks Casey! I'll rebase and tag you to activate the testing.

MengnanLi91 added a commit to MengnanLi91/crane that referenced this pull request Oct 19, 2023
@MengnanLi91 MengnanLi91 force-pushed the input_vector_parameter_fix branch from 0169c6e to 7122fd8 Compare October 19, 2023 19:03
@MengnanLi91 MengnanLi91 force-pushed the input_vector_parameter_fix branch from 7122fd8 to 7da886d Compare October 19, 2023 19:04
@MengnanLi91
Copy link
Contributor Author

@cticenhour Could you help me with testing?

@cticenhour
Copy link
Collaborator

@smpeyres This is passing testing and is ready to be merged. See https://civet.inl.gov/pr/19853/.

@smpeyres smpeyres merged commit dd21728 into lcpp-org:devel Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants