Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle the spaghetti #100

Closed
1 of 4 tasks
Macacoazul01 opened this issue Dec 14, 2022 · 3 comments
Closed
1 of 4 tasks

Untangle the spaghetti #100

Macacoazul01 opened this issue Dec 14, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Macacoazul01
Copy link
Collaborator

Macacoazul01 commented Dec 14, 2022 •
edited
Loading

There are many widgets generated by functions and things being done more than one time in the code.

What makes it hard to understand and to fix and also leads to perceptive performance problems.

Creating this issue to help dealing with this.

  • Separate big classes
  • Replace most or all widget functions for stateless or statefull widgets
  • Reduce repetitive actions
  • Clean unnecessary parts
@lcuis lcuis added the enhancement New feature or request label Dec 14, 2022
lcuis added a commit that referenced this issue Dec 14, 2022
@lcuis
2.2.0 Avoided a warning when validating a form with multiple objects.…
6351f6b 
… Thanks @Macacoazul01 #97 ; Separated big classes. Thanks @Macacoazul01 #100
@lcuis
Copy link
Owner

lcuis commented Dec 14, 2022

The separate big classes point is part of the 2.2.0 release published to pub.dev .

@Macacoazul01
Copy link
Collaborator Author

Can you help with the item 2?
I'm a little lost in the code😅

@lcuis
Copy link
Owner

lcuis commented Dec 14, 2022

Yes, item 2 would be quite easy for me though, a bit time consuming. As I am in a rush on other projects right now, I will have to take care of this at a later stage. Though, I am confident this will be a major gain in performance. Thanks a lot for the suggestion.

@Macacoazul01 Macacoazul01 added the help wanted Extra attention is needed label Dec 14, 2022
lcuis added a commit that referenced this issue Feb 1, 2023
@lcuis
2.2.2 INFO: 'subtitle1' is deprecated and shouldn't be used. Use titl…
9a58a68 
…eMedium instead. This feature was deprecated after v3.1.0-0.0.pre. ; compileSdkVersion 33 ; started with task 2 of #100 (transform some Widget function into classes)
lcuis added a commit that referenced this issue Feb 1, 2023
@lcuis
2.2.2 INFO: 'subtitle1' is deprecated and shouldn't be used. Use titl…
dd9ca31 
…eMedium instead. This feature was deprecated after v3.1.0-0.0.pre. ; compileSdkVersion 33 ; started with task 2 of #100 (transform some Widget function into classes)
lcuis added a commit that referenced this issue Feb 20, 2023
@lcuis
2.2.3 added buildFutureFilterOrOrderButton to customize future filter…
320471f 
… and order button. Thanks @agustin-garcia #107 ; continued with task 2 of #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcuis @Macacoazul01