-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CircleCI & AppVeyor for continuous & release deployment #2438
Conversation
60cc843
to
e3185c3
Compare
4a2d8b7
to
e203663
Compare
36056a7
to
a32770f
Compare
9828370
to
a3404c4
Compare
Looking very good. Summary:
The dynamic-compile lit tests are also failing for the OSX multilib job (
What's left, besides fixing the CircleCI OSX job, is treating tagged builds slightly differently. I'd like to use the LLVM build with enabled assertions for regular CI builds and the one without asserts for tagged builds. The other difference is that the GitHub release to upload the artifact to is a different one and that the filename needs to be adapted. So after this tedious work,
|
You can create a docker image based on |
I know, we've been using a Docker image for the official release packages for some months now. While it would save about 4-5 mins for each CircleCI Linux job (depending on whether it also includes LLVM, as our existing Docker image does), it would also shift some of the maintenance burden back to us instead of letting the CI services take care of almost everything, which is my primary motivation. |
CircleCI Linux now fails to build dub with assertions-enabled LLVM; it's apparently built with optimizations and The libFuzzer lit tests fail sporadically and rather frequently for CircleCI |
49aaa39
to
c123a65
Compare
Somebody on OSX please verify that the package works as expected (CircleCI OSX log -> click on I tested the Windows and Linux packages, they are fine. The Windows multilib artifact and GitHub uploads can only be tested after merging this; the release packages will be tested on the next LDC tag. |
As for the previous non-CI release archives.
And fix its version, relevant for the .so links.
Seems to work fine on macOS 10.12 after some cursory tests. #2442 applies to all release packages, though. |
(Xcode 9.0.1 with a 10.8 deployment target should be fine; this is what we have been using for previous releases.) |
* Don't download & extract SPIR-V LLVM if present in cache. * Remove OSX multilib CMake test; that is properly tested via CircleCI now.
Thx for testing, David. For those who wonder, the LDC-LLVM 5.0.0-2 GitHub artifacts (used by LDC's CircleCI and AppVeyor) have been obtained by downloading, renaming and re-uploading the latest LLVM CI build artifacts (and so the name of the top-level directory in the archives doesn't match the archive name, and the LLVM version string includes the Wrt. improved OSX test coverage, we not only test |
Just a reminder about the issue found with Ubuntu 14.04: #2390. It's not at all the same thing, but wanted to raise it in case a switch to 16.04 is warranted. (The reason the issue is closed is because 16.04 avoids it.) |
Creating a release is incredibly painless now. Only caveat is that the GitHub release should be published (no draft) as soon as the tag is pushed; AppVeyor needs it (stable download links) in order to download the previously generated x64 artifact for generating the multilib one as part of the x86 job. So the overall release workflow is simplified to:
The armhf package is the only file which still needs to be generated and uploaded manually. |
No description provided.