-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor to simple parser approach #13
Open
ThomasWeinert
wants to merge
14
commits into
ldionne:master
Choose a base branch
from
ThomasWeinert:feature/snippet-parser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Refactor to simple parser approach #13
ThomasWeinert
wants to merge
14
commits into
ldionne:master
from
ThomasWeinert:feature/snippet-parser
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific patterns Add jsdoc namespace and documentation
…documentation from bower package remove version (should be a git tag)
Ignore trailing line break at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading the open issues I started to refactor the source for them and it got a little out of hand. :-P
It is a complete refactoring, changing the approach to a small line parser for the files.
Sampler.Files
keeps track of the requested files and createsSampler.File
objects with named samples and lines. TheSampler.Line
objects store the line content, number and type. It allows the files to be fetched and parsed once only.Sampler.Sample
appends the selected snippets/lines.