Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor to simple parser approach #13

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ThomasWeinert
Copy link
Contributor

@ThomasWeinert ThomasWeinert commented Dec 12, 2018

After reading the open issues I started to refactor the source for them and it got a little out of hand. :-P

It is a complete refactoring, changing the approach to a small line parser for the files. Sampler.Files keeps track of the requested files and creates Sampler.File objects with named samples and lines. The Sampler.Line objects store the line content, number and type. It allows the files to be fetched and parsed once only. Sampler.Sample appends the selected snippets/lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant