Remove getenv by using _env and $_ENV instead
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
The
getenvfunction is not thread-safe. (See vlucas/phpdotenv#putenv-and-getenv) It breaks the core functionality of web sites.In this pull request, I have removed
getenvand made the module use Leaf's_envfunction instead to get environment variables. The change ensures that the functionality of this module does not break if you merge leafsphp/leaf#253 with the default branch of the main repo.I could not run the tests. The credentials are not valid.
I didn't check all Leaf modules for
getenv, but all of its occurrences in modules should be replaced with_envand$_ENV.Does this PR introduce a breaking change? (check one)
Related Pull Request
leafsphp/leaf#253