Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bloc related APIs to comms package #60

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Move bloc related APIs to comms package #60

merged 2 commits into from
Jul 20, 2023

Conversation

lewandowski-jan
Copy link
Collaborator

@lewandowski-jan lewandowski-jan commented Jul 20, 2023 •
edited
Loading

  • update changelog and pubspec version

  • add bloc package

  • add ListenerBloc, ListenerCubit and StateSender

  • add tests

  • extract ProductCountChangedMessage to seperate file

Related to #59

@lewandowski-jan lewandowski-jan added the package:comms For stuff related to comms package label Jul 20, 2023
@lewandowski-jan lewandowski-jan self-assigned this Jul 20, 2023
@lewandowski-jan
Copy link
Collaborator Author

in next PR I will remove them from flutter_comms package

@lewandowski-jan lewandowski-jan force-pushed the chore/59-move-bloc-related-apis branch from c9cac6c to 555d164 Compare July 20, 2023 16:05
@lewandowski-jan
Move bloc related APIs to comms package
bca92b1 
- update changelog and pubspec version

- add bloc package

- add ListenerBloc, ListenerCubit and StateSender

- add tests

- extract ProductCountChangedMessage to seperate file

Related to #59
@lewandowski-jan lewandowski-jan force-pushed the chore/59-move-bloc-related-apis branch from 555d164 to bca92b1 Compare July 20, 2023 16:06
bartekpacia
bartekpacia approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@bartekpacia bartekpacia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Offtop 1: I think a full-blown docs website would do much good to this package's adoption (both among internal & external users).

Offtop 2: Should it, in the future, be added to flutter_corelibrary? see also leancodepl/flutter_corelibrary#133

@lewandowski-jan lewandowski-jan merged commit 0049c21 into master Jul 20, 2023
1 check passed
@lewandowski-jan lewandowski-jan deleted the chore/59-move-bloc-related-apis branch July 20, 2023 16:27
@lewandowski-jan
Copy link
Collaborator Author

Offtop 1: I think a full-blown docs website would do much good to this package's adoption (both among internal & external users).

You are right, but maybe this package is not yet as popular to have that.

Offtop 2: Should it, in the future, be added to flutter_corelibrary? see also leancodepl/flutter_corelibrary#133

I think this package could be more independent, putting it there would sound like it's just for internal use.

@bartekpacia
Copy link
Contributor

I agree with both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia approved these changes

Assignees

@lewandowski-jan lewandowski-jan

Labels
package:comms For stuff related to comms package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewandowski-jan @bartekpacia