Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adjust to new termination_by syntax #446

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 13, 2023

this makes the necessary changes to compile with the termination_by
syntax refactoring in leanprover/lean4#3040.

this makes the necessary changes to compile with the `termination_by`
syntax refactoring in leanprover/lean4#3040
@nomeata nomeata changed the title lean pr testing 3040 refactor: Adjust to new termination_by syntax Dec 13, 2023
@nomeata nomeata changed the base branch from main to nightly-testing December 13, 2023 13:46
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 13, 2023
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 13, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 14, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 20, 2023
@fgdorais fgdorais added depends on core changes This PR need only be reviewed after changes land in Lean core. v4.5.0 labels Dec 21, 2023
@fgdorais
Copy link
Collaborator

fgdorais commented Dec 21, 2023

Not sure if the tag v4.5.0 was appropriate. Please change if necessary. Also, please add a status tag (WIP, awaiting-review, awaiting-author) unless that doesn't make sense.

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 21, 2023

I guess the draft PR status duplicates the WIP label information?

Anyways, once we know when leanprover/lean4#3040 will land we'll know when to proceed here.

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 21, 2023

WIP

@github-actions github-actions bot added the WIP work in progress label Dec 21, 2023
@fgdorais
Copy link
Collaborator

Thanks! It's really just to help managing the PR queue, even if the info is duplicated.

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 21, 2023

Have you considered ignoring draft PRs in the queue?

@fgdorais
Copy link
Collaborator

I do but it's not that common to use draft PRs on Std. Most people just keep those on their own forks. It only takes a second look for a draft but WIP just takes one look and it's at the same place as all the other useful info.

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 21, 2023

Got it, will try to remember to WIP my draft PRs!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 21, 2023
@kim-em kim-em added v4.6.0 This PR needs to wait until we move to `v4.6.0`. It will be merged to `nightly-testing` first. and removed v4.5.0 labels Dec 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 22, 2023
@kim-em
Copy link
Collaborator

kim-em commented Jan 18, 2024

I'm closing this, as it's already been merged to both nightly-testing and bump/v4.6.0.

@kim-em kim-em closed this Jan 18, 2024
@nomeata nomeata deleted the lean-pr-testing-3040 branch January 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on core changes This PR need only be reviewed after changes land in Lean core. merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. v4.6.0 This PR needs to wait until we move to `v4.6.0`. It will be merged to `nightly-testing` first. WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants