-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New simp lemmas can remove old ones from simp set #163
Comments
7 tasks
mergify bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this issue
Apr 2, 2020
This PR fixes some bugs in the `simp_nf` linter. Previously it ignored all errors (from failing tactics). I've changed this so that errors from linters are handled centrally and reported as linter warnings. The `simp_is_conditional` function was also broken. As usual, new linters find new issues: 1. Apparently Lean sometimes throws away simp lemmas. leanprover-community/lean#163 2. Some types define `has_coe` but have an incorrect `has_coe_to_fun`, causing the simplifier to loop `⇑f a = ⇑↑f a = ⇑f a`. See the new library note:
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this issue
May 15, 2020
…#2266) This PR fixes some bugs in the `simp_nf` linter. Previously it ignored all errors (from failing tactics). I've changed this so that errors from linters are handled centrally and reported as linter warnings. The `simp_is_conditional` function was also broken. As usual, new linters find new issues: 1. Apparently Lean sometimes throws away simp lemmas. leanprover-community/lean#163 2. Some types define `has_coe` but have an incorrect `has_coe_to_fun`, causing the simplifier to loop `⇑f a = ⇑↑f a = ⇑f a`. See the new library note:
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this issue
May 16, 2020
…#2266) This PR fixes some bugs in the `simp_nf` linter. Previously it ignored all errors (from failing tactics). I've changed this so that errors from linters are handled centrally and reported as linter warnings. The `simp_is_conditional` function was also broken. As usual, new linters find new issues: 1. Apparently Lean sometimes throws away simp lemmas. leanprover-community/lean#163 2. Some types define `has_coe` but have an incorrect `has_coe_to_fun`, causing the simplifier to loop `⇑f a = ⇑↑f a = ⇑f a`. See the new library note:
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this issue
Mar 15, 2022
…#2266) This PR fixes some bugs in the `simp_nf` linter. Previously it ignored all errors (from failing tactics). I've changed this so that errors from linters are handled centrally and reported as linter warnings. The `simp_is_conditional` function was also broken. As usual, new linters find new issues: 1. Apparently Lean sometimes throws away simp lemmas. leanprover-community/lean#163 2. Some types define `has_coe` but have an incorrect `has_coe_to_fun`, causing the simplifier to loop `⇑f a = ⇑↑f a = ⇑f a`. See the new library note:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: