Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(library/init/data/int/order): remove double namespaces, protect nat and int lemmas #245

Closed
wants to merge 4 commits into from

Conversation

bryangingechen
Copy link
Collaborator

@bryangingechen bryangingechen commented May 16, 2020

This PR protects the lemmas listed in leanprover-community/mathlib3@85ce04a since they are superseded in mathlib. They were all added in #229.

Also, this PR removes:

  • int.mul_sub_left_distrib in favor of the shorter int.mul_sub,
  • int.mul_sub_right_distrib in favor of the shorter int.sub_mul.

Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/preparing.20for.20lean-3.2E13.2E0/near/197817609

@bryangingechen bryangingechen added the WIP Work in progress label May 16, 2020
also rename:
- int.mul_sub_left_distrib
  -> int.mul_sub,
- int.mul_sub_right_distrib
  -> int.sub_mul
@bryangingechen bryangingechen changed the title fix(library/init/data/int/order): remove double namespaces fix(library/init/data/int/order): remove double namespaces, protect nat and int lemmas May 17, 2020
@bryangingechen bryangingechen removed the WIP Work in progress label May 17, 2020
@bryangingechen
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request May 17, 2020
…at and int lemmas (#245)

This PR protects the lemmas listed in leanprover-community/mathlib3@85ce04a since they are superseded in mathlib. They were all added in #229. 

Also, this PR removes:
- `int.mul_sub_left_distrib` in favor of the shorter `int.mul_sub`,
- `int.mul_sub_right_distrib` in favor of the shorter `int.sub_mul`.

Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/preparing.20for.20lean-3.2E13.2E0/near/197817609
@bors
Copy link

bors bot commented May 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(library/init/data/int/order): remove double namespaces, protect nat and int lemmas [Merged by Bors] - fix(library/init/data/int/order): remove double namespaces, protect nat and int lemmas May 17, 2020
@bors bors bot closed this May 17, 2020
@bors bors bot deleted the fix_int_int branch May 17, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant