-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(CategoryTheory): the left Kan extension functor #12168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the variable names throughout the folder Functor/KanExtension
more consistent? For example, always use L: C ⥤ D
for the "along" functor and F : C ⥤ E
for the "of" functor (or whatever). It's a bit confusing that F
becomes the "along" functor in the adjunction file when it was the "of" functor in the basic file, and also the categories changed names.
Thanks @dagurtomas for the suggestion. It was indeed very confusing... Now, we extend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Thanks! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! 1 minor request.
bors d+
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks! bors merge |
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
Pull request successfully merged into master. Build succeeded: |
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
Given a functor
F : C ⥤ D
, we define the left Kan extension functorF.lan : (C ⥤ E) ⥤ (D ⥤ E)
which sends a functorG : C ⥤ E
to its left Kan extension alongF
. (This is a step towards the refactor ofLan/Ran
in mathlib using the new API for Kan extensions of functors #10425.)