Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): the left Kan extension functor #12168

Closed
wants to merge 5 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Apr 16, 2024

Given a functor F : C ⥤ D, we define the left Kan extension functor F.lan : (C ⥤ E) ⥤ (D ⥤ E) which sends a functor G : C ⥤ E to its left Kan extension along F. (This is a step towards the refactor of Lan/Ran in mathlib using the new API for Kan extensions of functors #10425.)


Open in Gitpod

Copy link
Collaborator

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the variable names throughout the folder Functor/KanExtension more consistent? For example, always use L: C ⥤ D for the "along" functor and F : C ⥤ E for the "of" functor (or whatever). It's a bit confusing that F becomes the "along" functor in the adjunction file when it was the "of" functor in the basic file, and also the categories changed names.

@joelriou
Copy link
Collaborator Author

Thanks @dagurtomas for the suggestion. It was indeed very confusing... Now, we extend F : C ⥤ H along L : C ⥤ D. I use the category H because E is sometimes used for terms in LeftExtension L F. (Doing so, the notations will be more consistent with the future API for derived functors, where L shall be a localization functor.)

Copy link
Collaborator

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@erdOne
Copy link
Member

erdOne commented Apr 20, 2024

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! 1 minor request.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Apr 20, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@joelriou
Copy link
Collaborator Author

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 20, 2024
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Apr 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): the left Kan extension functor [Merged by Bors] - feat(CategoryTheory): the left Kan extension functor Apr 20, 2024
@mathlib-bors mathlib-bors bot closed this Apr 20, 2024
@mathlib-bors mathlib-bors bot deleted the kan-extension-4 branch April 20, 2024 19:23
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
Given a functor `F : C ⥤ D`, we define the left Kan extension functor `F.lan : (C ⥤ E) ⥤ (D ⥤ E)` which sends a functor `G : C ⥤ E` to its left Kan extension along `F`. (This is a step towards the refactor of `Lan/Ran` in mathlib using the new API for Kan extensions of functors #10425.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants