Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Fintype/Basic): Finset.univ_map_subtype lemmas #12903

Closed
wants to merge 5 commits into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented May 14, 2024

Copy link
Collaborator

@rosborn rosborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me although I'd suggest renaming univ_val_map_subtype to univ_val_map_subtype_val and univ_val_map_subtype_val to univ_val_map_subtype_restrict.

Mathlib/Data/Fintype/Basic.lean Outdated Show resolved Hide resolved
madvorak and others added 2 commits May 14, 2024 15:19
@madvorak
Copy link
Collaborator Author

These look good to me although I'd suggest renaming univ_val_map_subtype to univ_val_map_subtype_val and univ_val_map_subtype_val to univ_val_map_subtype_restrict.

Done. Thanks for suggestion!

Mathlib/Data/Fintype/Basic.lean Outdated Show resolved Hide resolved
madvorak and others added 2 commits June 12, 2024 08:55
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Copy link

PR summary 41a8ebe2cc

Import changes

No significant changes to the import graph


Declarations diff

+ univ_map_subtype
+ univ_val_map_subtype_restrict
+ univ_val_map_subtype_val

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 17, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 17, 2024

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Fintype/Basic): Finset.univ_map_subtype lemmas [Merged by Bors] - feat(Data/Fintype/Basic): Finset.univ_map_subtype lemmas Jun 17, 2024
@mathlib-bors mathlib-bors bot closed this Jun 17, 2024
@mathlib-bors mathlib-bors bot deleted the finset_univ_map_subtype_filter branch June 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants