-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Fintype/Basic): Finset.univ_map_subtype
lemmas
#12903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me although I'd suggest renaming univ_val_map_subtype
to univ_val_map_subtype_val
and univ_val_map_subtype_val
to univ_val_map_subtype_restrict
.
Co-authored-by: Richard Osborn <richardosborn@mac.com>
Done. Thanks for suggestion! |
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
PR summary 41a8ebe2ccImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Thanks! bors merge |
Co-authored-by: Richard Copley <rcopley@gmail.com> Discussion: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Finset.2Euniv.2Esum.20split
Build failed (retrying...): |
Co-authored-by: Richard Copley <rcopley@gmail.com> Discussion: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Finset.2Euniv.2Esum.20split
Pull request successfully merged into master. Build succeeded: |
Finset.univ_map_subtype
lemmasFinset.univ_map_subtype
lemmas
Co-authored-by: Richard Copley <rcopley@gmail.com> Discussion: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Finset.2Euniv.2Esum.20split
Co-authored-by: Richard Copley <rcopley@gmail.com> Discussion: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Finset.2Euniv.2Esum.20split
Co-authored-by: Richard Copley rcopley@gmail.com
Discussion:
https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Finset.2Euniv.2Esum.20split