chore: redefine Nat.bit Nat.div2 Nat.bodd
#13649
Open
+68
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FR-vdash-bot
changed the title
Nat.binaryRec Nat.div2 Nat.bodd
PR summary 7e64fc89b0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
1 task
|
Please describe how and why did you change the definition(s) in the commit message. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
eric-wieser
reviewed
Aug 6, 2024
eric-wieser
reviewed
Aug 6, 2024
| /-- `bit b` appends the digit `b` to the little end of the binary representation of | ||
| its natural number input. -/ | ||
| def bit (b : Bool) (n : Nat) : Nat := | ||
| cond b (n <<< 1 + 1) (n <<< 1) |
There was a problem hiding this comment.
Presumably | 1 is also faster than + 1, if you're really micro-optimizing?
There was a problem hiding this comment.
It's not faster in my tests. Also it would make proofs much more complicated.
eric-wieser
reviewed
Aug 6, 2024
4 tasks
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
FR-vdash-bot
changed the title
Nat.binaryRec Nat.div2 Nat.boddNat.bit Nat.div2 Nat.bodd
leanprover-community-bot-assistant
added
the
merge-conflict
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 20, 2024
This is #13649 with fewer definition changes.
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
|
@FR-vdash-bot, please solve the merge conflicts. |
leanprover-community-bot-assistant
removed
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new definitions are faster than the old ones.
Nat.binaryRecwill be moved to batteries (leanprover-community/batteries#799) or core (leanprover/lean4#3756), so relevant contents are moved to a new file temporarily.Natinto a new file #15567