Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize fract_div_intCast_eq_div_intCast_mod #14756

Closed
wants to merge 8 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jul 15, 2024


Open in Gitpod

Copy link

github-actions bot commented Jul 15, 2024

PR summary 76507f175f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Floor 603 609 +6 (+1.00%)
Import changes for all files
Files Import difference
Mathlib.Order.Filter.AtTopBot.Floor 5
5 files Mathlib.Algebra.ContinuedFractions.Computation.Translations Mathlib.Algebra.Order.Floor Mathlib.Algebra.ContinuedFractions.Computation.Basic Mathlib.Data.Int.Log Mathlib.Algebra.Order.Nonneg.Floor
6

Declarations diff

+ fmod_nonpos
+ fract_div_intCast_eq_div_intCast_fmod
+ fract_eq_zero_iff
+ lt_fmod_of_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
5027 -2 porting notes

Current commit 76507f175f
Reference commit 496527772a

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mo271
Copy link
Collaborator Author

mo271 commented Jul 15, 2024

TODO Generalise this to allow `n : ℤ` using `Int.fmod` instead of `Int.mod`.`

was added in leanprover-community/mathlib3#17321 by @ocfnash

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2024
@grunweg grunweg added the t-algebra Algebra (groups, rings, fields, etc) label Aug 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 16, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 4, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 29, 2024
@mo271 mo271 added the awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there label Nov 29, 2024
@mo271
Copy link
Collaborator Author

mo271 commented Dec 1, 2024

closing in favor of #19652

@mo271 mo271 closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants