-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generalize fract_div_intCast_eq_div_intCast_mod
#14756
Closed
Closed
+98
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mo271
commented
Jul 15, 2024
PR summary 76507f175f
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Order.Floor | 603 | 609 | +6 (+1.00%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Order.Filter.AtTopBot.Floor |
5 |
5 filesMathlib.Algebra.ContinuedFractions.Computation.Translations Mathlib.Algebra.Order.Floor Mathlib.Algebra.ContinuedFractions.Computation.Basic Mathlib.Data.Int.Log Mathlib.Algebra.Order.Nonneg.Floor |
6 |
Declarations diff
+ fmod_nonpos
+ fract_div_intCast_eq_div_intCast_fmod
+ fract_eq_zero_iff
+ lt_fmod_of_pos
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number | Change | Type |
---|---|---|
5027 | -2 | porting notes |
Current commit 76507f175f
Reference commit 496527772a
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
was added in leanprover-community/mathlib3#17321 by @ocfnash |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 19, 2024
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Sep 16, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 4, 2024
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Nov 29, 2024
mo271
added
the
awaiting-zulip
There is a Zulip discussion; the author should await and report/implement the decision reached there
label
Nov 29, 2024
closing in favor of #19652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-zulip
There is a Zulip discussion; the author should await and report/implement the decision reached there
t-algebra
Algebra (groups, rings, fields, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.