Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adaptations for nightly-2024-09-11 #16716

Merged
merged 2,405 commits into from
Sep 13, 2024
Merged

Conversation

jcommelin
Copy link
Member

No description provided.

kim-em and others added 30 commits August 27, 2024 20:55
comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def

comp_def
reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq

reduceCtorEq
adaption_note / sorry

adaptation_note / sorry

adaptation_note / sorry
Copy link

github-actions bot commented Sep 12, 2024

PR summary f2afc35678

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Nat.Cast.NeZero 96 76 -20 (-20.83%)
Mathlib.Algebra.CharZero.Defs 104 103 -1 (-0.96%)
Mathlib.Algebra.Order.ZeroLEOne 118 117 -1 (-0.85%)
Mathlib.Data.PNat.Defs 137 136 -1 (-0.73%)
Import changes for all files
Files Import difference
Mathlib.Data.Nat.Cast.NeZero -20
9 files Mathlib.Data.Nat.Cast.WithTop Mathlib.Data.PNat.Equiv Mathlib.Data.PNat.Defs Mathlib.Algebra.Order.ZeroLEOne Mathlib.Algebra.Order.Monoid.NatCast Mathlib.Algebra.CharZero.Defs Mathlib.Algebra.Order.SuccPred Mathlib.Algebra.Order.Monoid.Unbundled.WithTop Mathlib.Algebra.Ring.Nat
-1

Declarations diff

+ binaryRec_one
- Nat.pos_of_neZero
- NeZero
- NeZero.ne
- NeZero.ne'
- Zero.{u}
- append_eq_cons_iff
- cons_eq_append_iff
- countP_join
- count_join
- getElem_attach
- getLast?_isSome
- instance (priority := 200) Zero.ofOfNat0 {α} [OfNat α (nat_lit 0)] : Zero α
- instance (priority := 300) Zero.toOfNat0 {α} [Zero α] : OfNat α (nat_lit 0)
- map_bind
- map_pbind
- map_tail
- mem_of_mem_getLast?
- mem_of_mem_head?
- neZero_iff
- neZero_zero_iff_false
- pmap_eq_none_iff
- pmap_eq_some_iff
- pmap_none
- pmap_some
- succ
- toExpr
- xor_assoc
- xor_comm
- xor_self
- xor_zero
- zero_xor

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Mathlib/Algebra/Order/Group/Defs.lean Show resolved Hide resolved
Mathlib/Data/Int/Interval.lean Outdated Show resolved Hide resolved
Mathlib/Geometry/Manifold/Sheaf/LocallyRingedSpace.lean Outdated Show resolved Hide resolved
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the failing build.
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 12, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin merged commit a6e46d2 into bump/v4.13.0 Sep 13, 2024
7 checks passed
@mathlib-bors mathlib-bors bot deleted the bump/nightly-2024-09-11 branch September 13, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants