-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: match the definition of AnalyticWithinAt
with ContDiffWithinAt
#16725
Conversation
PR summary 5b34af5477Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Thanks 🎉 bors merge bors merge |
Already running a review |
…nAt` (#16725) The current definition of `AnalyticWithinAt` in a set `s` at a point `x` requires good behavior inside `s`, and continuity within `s` at `x` (because good behavior at `x` is important). In `ContDiffWithinAt`, where the issues are similar, one requires instead good behavior inside `insert x s`. Those two points of view are equivalent, but the latter is often more convenient (just one field to check, more uniform proofs). In this PR, we switch the definition of `AnalyticWithinAt` to the latter approach. We also expand a little bit the API around `AnalyticWithinAt`, by tweaking theorems that required `AnalyticAt` to require `AnalyticWithinAt`, and deduce `AnalyticAt` versions from `AnalyticWithinAt` versions. For this, a few statements have to be moved from the file `Analytic.Within.lean` to `Analytic.Basic.lean`. There is no real new statement or new proof in this PR, but it opens the way to further improvements.
Pull request successfully merged into master. Build succeeded: |
AnalyticWithinAt
with ContDiffWithinAt
AnalyticWithinAt
with ContDiffWithinAt
The current definition of
AnalyticWithinAt
in a sets
at a pointx
requires good behavior insides
, and continuity withins
atx
(because good behavior atx
is important). InContDiffWithinAt
, where the issues are similar, one requires instead good behavior insideinsert x s
. Those two points of view are equivalent, but the latter is often more convenient (just one field to check, more uniform proofs).In this PR, we switch the definition of
AnalyticWithinAt
to the latter approach. We also expand a little bit the API aroundAnalyticWithinAt
, by tweaking theorems that requiredAnalyticAt
to requireAnalyticWithinAt
, and deduceAnalyticAt
versions fromAnalyticWithinAt
versions. For this, a few statements have to be moved from the fileAnalytic.Within.lean
toAnalytic.Basic.lean
.There is no real new statement or new proof in this PR, but it opens the way to further improvements.