Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: match the definition of AnalyticWithinAt with ContDiffWithinAt #16725

Closed
wants to merge 5 commits into from

Conversation

sgouezel
Copy link
Contributor

The current definition of AnalyticWithinAt in a set s at a point x requires good behavior inside s, and continuity within s at x (because good behavior at x is important). In ContDiffWithinAt, where the issues are similar, one requires instead good behavior inside insert x s. Those two points of view are equivalent, but the latter is often more convenient (just one field to check, more uniform proofs).

In this PR, we switch the definition of AnalyticWithinAt to the latter approach. We also expand a little bit the API around AnalyticWithinAt, by tweaking theorems that required AnalyticAt to require AnalyticWithinAt, and deduce AnalyticAt versions from AnalyticWithinAt versions. For this, a few statements have to be moved from the file Analytic.Within.lean to Analytic.Basic.lean.

There is no real new statement or new proof in this PR, but it opens the way to further improvements.


Open in Gitpod

Copy link

PR summary 5b34af5477

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AnalyticWithinAt.continuousWithinAt_insert
+ HasFPowerSeriesAt.hasFPowerSeriesWithinAt
+ HasFPowerSeriesOnBall.hasFPowerSeriesWithinOnBall
+ HasFPowerSeriesWithinAt.analyticWithinAt
+ HasFPowerSeriesWithinAt.coeff_zero
+ HasFPowerSeriesWithinAt.congr
+ HasFPowerSeriesWithinAt.continuousWithinAt_insert
+ HasFPowerSeriesWithinAt.eventually
+ HasFPowerSeriesWithinAt.isBigO_image_sub_norm_mul_norm_sub
+ HasFPowerSeriesWithinAt.isBigO_sub_partialSum_pow
+ HasFPowerSeriesWithinOnBall.analyticWithinAt
+ HasFPowerSeriesWithinOnBall.coeff_zero
+ HasFPowerSeriesWithinOnBall.congr
+ HasFPowerSeriesWithinOnBall.continuousOn
+ HasFPowerSeriesWithinOnBall.continuousWithinAt
+ HasFPowerSeriesWithinOnBall.continuousWithinAt_insert
+ HasFPowerSeriesWithinOnBall.hasFPowerSeriesWithinAt
+ HasFPowerSeriesWithinOnBall.hasSum_sub
+ HasFPowerSeriesWithinOnBall.image_sub_sub_deriv_le
+ HasFPowerSeriesWithinOnBall.isBigO_image_sub_image_sub_deriv_principal
+ HasFPowerSeriesWithinOnBall.of_le
+ HasFPowerSeriesWithinOnBall.radius_pos
+ HasFPowerSeriesWithinOnBall.tendstoLocallyUniformlyOn
+ HasFPowerSeriesWithinOnBall.tendstoLocallyUniformlyOn'
+ HasFPowerSeriesWithinOnBall.tendstoUniformlyOn
+ HasFPowerSeriesWithinOnBall.tendstoUniformlyOn'
+ HasFPowerSeriesWithinOnBall.uniform_geometric_approx
+ HasFPowerSeriesWithinOnBall.uniform_geometric_approx'
+ MapsTo.insert
+ _
+ analyticWithinAt_iff_exists_analyticAt'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge
Thanks 🎉

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 12, 2024

Already running a review

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 12, 2024
…nAt` (#16725)

The current definition of `AnalyticWithinAt` in a set `s` at a point `x` requires good behavior inside `s`, and continuity within `s` at `x` (because good behavior at `x` is important). In `ContDiffWithinAt`, where the issues are similar, one requires instead good behavior inside `insert x s`. Those two points of view are equivalent, but the latter is often more convenient (just one field to check, more uniform proofs). 

In this PR, we switch the definition of `AnalyticWithinAt` to the latter approach. We also expand a little bit the API around `AnalyticWithinAt`, by tweaking theorems that required `AnalyticAt` to require `AnalyticWithinAt`, and deduce `AnalyticAt` versions from `AnalyticWithinAt` versions. For this, a few statements have to be moved from the file `Analytic.Within.lean` to `Analytic.Basic.lean`.

There is no real new statement or new proof in this PR, but it opens the way to further improvements.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: match the definition of AnalyticWithinAt with ContDiffWithinAt [Merged by Bors] - chore: match the definition of AnalyticWithinAt with ContDiffWithinAt Sep 12, 2024
@mathlib-bors mathlib-bors bot closed this Sep 12, 2024
@mathlib-bors mathlib-bors bot deleted the SG_analyticwithin branch September 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants