-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Analysis/InnerProductSpace): weaken assumptions to SeminormedAddCommGroup
#17007
Conversation
PR summary 0f88afc31fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for |
!bench |
Here are the benchmark results for commit 94fe59e. |
I span off #17011 from this; I think that in turn will make some sections more generalizable. |
SemiNormedAddCommGroup
SemiNormedAddCommGroup
SemiNormedAddCommGroup
SemiNormedAddCommGroup
@@ -27,7 +27,7 @@ namespace UniformSpace | |||
|
|||
namespace Completion | |||
|
|||
variable (𝕜 E : Type*) [NormedField 𝕜] [NormedAddCommGroup E] [NormedSpace 𝕜 E] | |||
variable (𝕜 E : Type*) [NormedField 𝕜] [SeminormedAddCommGroup E] [NormedSpace 𝕜 E] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a much more thorough version of this in #17059, but they can be merged in either order.
I managed to solve this for you with a |
SemiNormedAddCommGroup
SeminormedAddCommGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks good to me; I think there are probably more generalizations possible elsewhere, but this already hits quite a lot of them!
Were there any more you wanted help with, or can the help-wanted
label go?
Yes, I only checked Could you please tell me why |
SeminormedAddCommGroup
SeminormedAddCommGroup
@yoh-tanimoto I think Eric already explained this above. The issue is that the instance it was trying to use required |
bors merge |
…ddCommGroup` (#17007) replace the assumption `NormedAddCommGroup` to `SemiNormedAddCommGroup` in various places. motivation: with the weakened assumption the results apply to `InnerProductSpace` without `definite` assumption. This is suggested in #16707, and continues from #14024. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Pull request successfully merged into master. Build succeeded: |
SeminormedAddCommGroup
SeminormedAddCommGroup
Actually the issue here was more subtle; the lemma was about a non-instance typeclass argument provided through a messy |
Yes, I meant that. Even with |
…ddCommGroup` (#17007) replace the assumption `NormedAddCommGroup` to `SemiNormedAddCommGroup` in various places. motivation: with the weakened assumption the results apply to `InnerProductSpace` without `definite` assumption. This is suggested in #16707, and continues from #14024. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
replace the assumption
NormedAddCommGroup
toSemiNormedAddCommGroup
in various places.motivation: with the weakened assumption the results apply to
InnerProductSpace
withoutdefinite
assumption.This is suggested in #16707, and continues from #14024.
I think it should be possible to do the same with
IsSymmetric.restrictScalars
butCompatibleSMul E E ℝ 𝕜
cannot be synthesized. Can anyone help?Are there other things that work with
SemiNormedAddCommGroup
?I noticed that in InnerProductSpace.Basic there are two instances of
InnerProductSpace ℝ ℂ
. Should I remove the latter?