Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move #help to Batteries (batteries#969) #17257

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Sep 29, 2024


Once batteries#969 is merged:

  • Edit lakefile to point batteries back to main
  • Run lake update batteries
  • Merge

Open in Gitpod

@fgdorais fgdorais added the blocked-by-batt-PR This PR depends on a PR to Batteries label Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

PR summary 5ca07e27b7

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.HelpCmd 18 0 -18 (-100.00%)
Mathlib.Tactic.Common 243 241 -2 (-0.82%)
Mathlib.Tactic 2279 2277 -2 (-0.09%)
Import changes for all files
Files Import difference
There are 4322 files with changed transitive imports taking up over 182682 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

- foo

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Sep 29, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 1, 2024
@fgdorais fgdorais removed the blocked-by-batt-PR This PR depends on a PR to Batteries label Oct 19, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 19, 2024
@fgdorais
Copy link
Collaborator Author

@kim-em We added #help to batteries but we forgot to delete it from Mathlib. This PR completes the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants