[Merged by Bors] - doc(NumberTheory/Ostrowski): tweak documentation #18028
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix doc --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (that is, before the `---`) using the following format: Moves: - Vector.* -> Mathlib.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [](https://gitpod.io/from-referrer/)
PR summary c88dedb3aeImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
github-actions
bot
added
the
t-number-theory
grunweg
changed the title
grunweg
changed the title
riccardobrasca
approved these changes
Oct 22, 2024
Mathlib/NumberTheory/Ostrowski.lean
Outdated
| @@ -236,15 +236,15 @@ lemma mulRingNorm_eq_one_of_not_dvd {m : ℕ} (hpm : ¬ p ∣ m) : f m = 1 := by | |||
| -- ## Step 4: f p = p ^ (- t) for some positive real t | |||
|
|
|||
| include hp0 hp1 hmin in | |||
| /-- The absolute value of `p` is `p ^ (-t)` for some positive real number `t`. -/ | |||
| /-- The absolute value of `p` is `p⁻ᵗ` for some positive real number `t`. -/ | |||
There was a problem hiding this comment.
I think we usually follow Lean notation in docstring (also below).
|
✌️ fbarroero can now approve this pull request. To approve and merge a pull request, simply reply with |
](https://gitpod.io/from-referrer/){kind=link}
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
This PR modifies the documentation of the file in the hope of improving it.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the documentation of the file in the hope of improving it.