Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: change definition of HasFTaylorSeries to take a parameter in WithTop ℕ∞ instead of ℕ∞ #18723

Closed
wants to merge 27 commits into from

Conversation

sgouezel
Copy link
Contributor

@sgouezel sgouezel commented Nov 7, 2024

For now this is useless (and even counter-productive, as it means we have to add some casts in some places), but it will make it possible to integrate analytic functions in the smooth hierarchy in #17152.


Open in Gitpod

Copy link

github-actions bot commented Nov 7, 2024

PR summary 0a2c40596a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HasFTaylorSeriesUpTo.of_le
+ hasFTaylorSeriesUpToOn_succ_nat_iff_right
+ hasFTaylorSeriesUpToOn_top_iff_add
+ hasFTaylorSeriesUpToOn_top_iff_right
+ hasFTaylorSeriesUpTo_fourierIntegral'
+ hasFTaylorSeriesUpTo_succ_nat_iff_right
+ natCast_le_of_coe_top_le_withTop
+ natCast_lt_of_coe_top_le_withTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Nov 7, 2024
sgouezel and others added 3 commits November 7, 2024 15:39
Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 8, 2024
lemma add_lt_add_iff_left {k : ℕ∞} (h : k ≠ ⊤) : k + n < k + m ↔ n < m :=
WithTop.add_lt_add_iff_left h

section withTop_enat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section names aren't all that important, but I think simply WithTop would be a better namespace here, as it's already in the ENat namespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep withTop_enat: otherwise, the section could be interpreted as a discussion on the relationship between ENat and WithTop Nat, and ways to go back and forth.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 9, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 16, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 18, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 20, 2024
…`WithTop ℕ∞` instead of `ℕ∞` (#18723)

For now this is useless (and even counter-productive, as it means we have to add some casts in some places), but it will make it possible to integrate analytic functions in the smooth hierarchy in #17152.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: change definition of HasFTaylorSeries to take a parameter in WithTop ℕ∞ instead of ℕ∞ [Merged by Bors] - feat: change definition of HasFTaylorSeries to take a parameter in WithTop ℕ∞ instead of ℕ∞ Nov 20, 2024
@mathlib-bors mathlib-bors bot closed this Nov 20, 2024
@mathlib-bors mathlib-bors bot deleted the SG_ftaylor_series branch November 20, 2024 14:09
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
…`WithTop ℕ∞` instead of `ℕ∞` (#18723)

For now this is useless (and even counter-productive, as it means we have to add some casts in some places), but it will make it possible to integrate analytic functions in the smooth hierarchy in #17152.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants