-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: change definition of HasFTaylorSeries
to take a parameter in WithTop ℕ∞
instead of ℕ∞
#18723
Conversation
PR summary 0a2c40596aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
lemma add_lt_add_iff_left {k : ℕ∞} (h : k ≠ ⊤) : k + n < k + m ↔ n < m := | ||
WithTop.add_lt_add_iff_left h | ||
|
||
section withTop_enat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section names aren't all that important, but I think simply WithTop
would be a better namespace here, as it's already in the ENat
namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep withTop_enat
: otherwise, the section could be interpreted as a discussion on the relationship between ENat
and WithTop Nat
, and ways to go back and forth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Pull request successfully merged into master. Build succeeded: |
HasFTaylorSeries
to take a parameter in WithTop ℕ∞
instead of ℕ∞
HasFTaylorSeries
to take a parameter in WithTop ℕ∞
instead of ℕ∞
For now this is useless (and even counter-productive, as it means we have to add some casts in some places), but it will make it possible to integrate analytic functions in the smooth hierarchy in #17152.