[Merged by Bors] - chore(RingTheory): split AlgebraicIndependent.lean
#19606
+987
−808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 23a2d80080
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.AlgebraicIndependent | 1445 | 0 | -1445 (-100.00%) |
| Mathlib.FieldTheory.SeparableDegree | 1477 | 1471 | -6 (-0.41%) |
| Mathlib.FieldTheory.IsAlgClosed.Classification | 1460 | 1456 | -4 (-0.27%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.AlgebraicIndependent |
-1445 |
10 filesMathlib.FieldTheory.IsPerfectClosure Mathlib.FieldTheory.SeparableClosure Mathlib.RingTheory.Unramified.Field Mathlib.FieldTheory.SeparableDegree Mathlib.FieldTheory.Galois.GaloisClosure Mathlib.RingTheory.Etale.Field Mathlib.FieldTheory.Galois.Profinite Mathlib.FieldTheory.CardinalEmb Mathlib.FieldTheory.JacobsonNoether Mathlib.FieldTheory.PurelyInseparable |
-6 |
Mathlib.FieldTheory.IsAlgClosed.Classification Mathlib.ModelTheory.Algebra.Field.IsAlgClosed |
-4 |
Mathlib.FieldTheory.AxGrothendieck |
-3 |
Mathlib.RingTheory.AlgebraicIndependent.Defs (new file) |
953 |
Mathlib.RingTheory.AlgebraicIndependent.Basic (new file) |
1130 |
Mathlib.RingTheory.AlgebraicIndependent.Transcendental (new file) |
1187 |
Mathlib.RingTheory.AlgebraicIndependent.Adjoin (new file) |
1431 |
Mathlib.RingTheory.AlgebraicIndependent.TranscendenceBasis (new file) |
1438 |
Mathlib.RingTheory.AlgebraicIndependent.RankAndCardinality (new file) |
1450 |
Declarations diff
+ AlgebraicIndependent.repr_ker
+ mono
- AlgebraicIndependent.mono
- repr_ker
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (5.00, 0.02)
| Current number | Change | Type |
|---|---|---|
| 223 | 5 | bare open (scoped) Classical |
Current commit 23a2d80080
Reference commit 675c28ea28
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
|
Good work! I think I'll come back after #19370 is merged, as currently the diffs are too big. |
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
leanprover-community-bot-assistant
added
the
merge-conflict
alreadydone
requested changes
Nov 30, 2024
Mathlib/RingTheory/AlgebraicIndependent/RankAndCardinality.lean
Outdated
Show resolved
Hide resolved
Mathlib/RingTheory/AlgebraicIndependent/RankAndCardinality.lean
Outdated
Show resolved
Hide resolved
Mathlib/RingTheory/AlgebraicIndependent/TranscendenceBasis.lean
Outdated
Show resolved
Hide resolved
alreadydone
added
the
awaiting-author
2 tasks
As a follow-up to splitting `RingTheory/Algebraic.lean`, also split `AlgebraicIndependent.lean`. This PR creates the following new files: * `AlgebraicIndependent/Defs.lean`: definition of `AlgebraicIndependent` and `IsTranscendenceBasis` * `AlgebraicIndependent/Basic.lean`: basic results on `AlgebraicIndependent` * `AlgebraicIndependent/TranscendenceBasis.lean`: basic results on `TranscendenceBasis` * `AlgebraicIndependent/Adjoin.lean`: relating `AlgebraicIndependent` and `IntermediateField.adjoin` * `AlgebraicIndependent/Transcendental.lean`: relating `AlgebraicIndependent`, `Transcendental` and `Algebraic` * `AlgebraicIndependent/RankAndCardinality.lean`: about the rank/cardinality of `TranscendenceBasis`es
Vierkantor
force-pushed
the
split-RingTheory.AlgebraicIndependent
branch
from
5d55382 to
e1183fc
Compare
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Vierkantor
removed
awaiting-author
alreadydone
approved these changes
Dec 2, 2024
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
|
Thanks! bors merge |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
As a follow-up to splitting `RingTheory/Algebraic.lean`, also split `AlgebraicIndependent.lean`. This PR creates the following new files: * `AlgebraicIndependent/Defs.lean`: definition of `AlgebraicIndependent` and `IsTranscendenceBasis` * `AlgebraicIndependent/Basic.lean`: basic results on `AlgebraicIndependent` * `AlgebraicIndependent/TranscendenceBasis.lean`: basic results on `TranscendenceBasis` * `AlgebraicIndependent/Adjoin.lean`: relating `AlgebraicIndependent` and `IntermediateField.adjoin` * `AlgebraicIndependent/Transcendental.lean`: relating `AlgebraicIndependent`, `Transcendental` and `Algebraic` * `AlgebraicIndependent/RankAndCardinality.lean`: about the rank/cardinality of `TranscendenceBasis`es Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
AlgebraicIndependent.leanAlgebraicIndependent.lean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to splitting
RingTheory/Algebraic.lean, also splitAlgebraicIndependent.lean.This PR creates the following new files:
AlgebraicIndependent/Defs.lean: definition ofAlgebraicIndependentandIsTranscendenceBasisAlgebraicIndependent/Basic.lean: basic results onAlgebraicIndependentAlgebraicIndependent/TranscendenceBasis.lean: basic results onTranscendenceBasisAlgebraicIndependent/Adjoin.lean: relatingAlgebraicIndependentandIntermediateField.adjoinAlgebraicIndependent/Transcendental.lean: relatingAlgebraicIndependent,TranscendentalandAlgebraicAlgebraicIndependent/RankAndCardinality.lean: about the rank/cardinality ofTranscendenceBasisesAlgebraic.lean#19370