Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Algebra.Homology.ShortComplex.Basic #4203

Closed
wants to merge 5 commits into from

Conversation

joelriou
Copy link
Collaborator

This PR introduces the category of short complexes X₁ ⟶ X₂ ⟶ X₃ in a category with zero morphisms.


This is the first PR in a series which intends to develop the homology of these short complexes, and redefining the homology in mathlib4. The whole code (which also includes the construction of derived categories) appear at #4197

Open in Gitpod

@joelriou joelriou changed the title feat: added Algebra.Homology.ShortComplex.Basic feat: Algebra.Homology.ShortComplex.Basic May 22, 2023
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks very uncontroversial :-) I left some minor comments.

of two composable morphisms `f : X₁ ⟶ X₂` and `g : X₂ ⟶ X₃` such that
`f ≫ g = 0`. -/
structure ShortComplex [HasZeroMorphisms C] where
/-- the three objects of a `ShortComplex` -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh heh, nice try :-) This gives that docstring to all three of the fields X1, X2, X3. Is that what you wanted?

This file defines the category `ShortComplex C` of diagrams
`X₁ ⟶ X₂ ⟶ X₃` such that the composition is zero.

TODO: An homology API for these objects shall be developped
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO: An homology API for these objects shall be developped
TODO: A homology API for these objects shall be developed

hom := ⟨e₁.hom, e₂.hom, e₃.hom, comm₁₂, comm₂₃⟩
inv := homMk e₁.inv e₂.inv e₃.inv
(by rw [← cancel_mono e₂.hom, assoc, assoc, e₂.inv_hom_id, comp_id,
← comm₁₂, e₁.inv_hom_id_assoc])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the spacing is correct here. Should this be under the rw rather than under the by? Not sure.

lemma isIso_of_isIso (f : S₁ ⟶ S₂) [IsIso f.τ₁] [IsIso f.τ₂] [IsIso f.τ₃] : IsIso f :=
IsIso.of_iso (isoMk (asIso f.τ₁) (asIso f.τ₂) (asIso f.τ₃) (by aesop_cat) (by aesop_cat))

/-- The opposite short_complex in `Cᵒᵖ` associated to a short complex in `C`. -/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- The opposite short_complex in `Cᵒᵖ` associated to a short complex in `C`. -/
/-- The opposite `ShortComplex` in `Cᵒᵖ` associated to a short complex in `C`. -/

@[simp]
lemma opMap_id : opMap (𝟙 S) = 𝟙 S.op := rfl

/-- The short_complex in `C` associated to a short complex in `Cᵒᵖ`. -/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- The short_complex in `C` associated to a short complex in `Cᵒᵖ`. -/
/-- The `ShortComplex` in `C` associated to a short complex in `Cᵒᵖ`. -/

@kim-em
Copy link
Contributor

kim-em commented May 24, 2023

Looks great, just the remaining minor comments.

bors d+

@bors
Copy link

bors bot commented May 24, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@joelriou
Copy link
Collaborator Author

Thanks very much @kbuzzard & @semorrison for these reviews!

bors r+

bors bot pushed a commit that referenced this pull request May 24, 2023
This PR introduces the category of short complexes `X₁ ⟶ X₂ ⟶ X₃` in a category with zero morphisms.
@bors
Copy link

bors bot commented May 24, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 24, 2023
This PR introduces the category of short complexes `X₁ ⟶ X₂ ⟶ X₃` in a category with zero morphisms.
@bors
Copy link

bors bot commented May 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Algebra.Homology.ShortComplex.Basic [Merged by Bors] - feat: Algebra.Homology.ShortComplex.Basic May 24, 2023
@bors bors bot closed this May 24, 2023
@bors bors bot deleted the shortcomplex_basic branch May 24, 2023 11:15
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
This PR introduces the category of short complexes `X₁ ⟶ X₂ ⟶ X₃` in a category with zero morphisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants