Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: composition of localization functors #6882

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: composition of localization functors #6882

wants to merge 15 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Aug 30, 2023 •
edited by github-actions bot
Loading

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Aug 30, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 30, 2023
@joelriou joelriou mentioned this pull request Aug 30, 2023
Open
@joelriou joelriou mentioned this pull request Aug 30, 2023
Closed
2 tasks
@joelriou joelriou removed the WIP Work in progress label Aug 30, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 5, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Sep 5, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 5, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 5, 2023
jcommelin
jcommelin approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/CategoryTheory/Localization/Composition.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 6, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@joelriou @jcommelin
Update Mathlib/CategoryTheory/Localization/Composition.lean
1fef6b6 
Co-authored-by: Johan Commelin <johan@commelin.net>
@joelriou
Copy link
Collaborator Author

joelriou commented Sep 6, 2023

Thanks for the review!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 6, 2023
bors bot pushed a commit that referenced this pull request Sep 6, 2023
@joelriou
feat: composition of localization functors (#6882)
c6da3b9 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 6, 2023

Build failed (retrying...):

@joelriou
Copy link
Collaborator Author

joelriou commented Sep 6, 2023

bors r-

@bors
Copy link

bors bot commented Sep 6, 2023

Canceled.

@joelriou
Copy link
Collaborator Author

joelriou commented Sep 6, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 6, 2023
@joelriou
feat: composition of localization functors (#6882)
c672a3f 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: composition of localization functors [Merged by Bors] - feat: composition of localization functors Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
@bors bors bot deleted the localization_composition branch September 6, 2023 16:43
ebab pushed a commit that referenced this pull request Sep 11, 2023
@joelriou @ebab
feat: composition of localization functors (#6882)
5d24827 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
@joelriou @kodyvajjha
feat: composition of localization functors (#6882)
4482d24 
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelriou @leanprover-community-mathlib4-bot @jcommelin