-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: exactness of short complexes #7052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under suitable assumptions, this new definition of exactness is equivalent to the existing one in mathlib. I understand that you plan to phase out the old definition. But in the mean time, I think it is good to provide a "glue" lemma that shows that the two are equivalent.
Thanks for the suggestions! I shall include a comparison lemma with the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
This PR introduces the definition of a proposition `S.Exact` when `S` is a short complex.
Build failed (retrying...): |
This PR introduces the definition of a proposition `S.Exact` when `S` is a short complex.
Build failed (retrying...): |
This PR introduces the definition of a proposition `S.Exact` when `S` is a short complex.
Build failed: |
bors retry |
This PR introduces the definition of a proposition `S.Exact` when `S` is a short complex.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This PR introduces the definition of a proposition `S.Exact` when `S` is a short complex.
This PR introduces the definition of a proposition
S.Exact
whenS
is a short complex.