Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - [Merged by Bors] - feat: pretriangulated categories have finite biproducts #7626

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - [Merged by Bors] - feat: pretriangulated categories have finite biproducts #7626

wants to merge 8 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Oct 11, 2023 •
edited
Loading

@joelriou joelriou added the t-category-theory Category theory label Oct 11, 2023
@joelriou joelriou mentioned this pull request Oct 11, 2023
Open
@joelriou joelriou mentioned this pull request Oct 12, 2023
Closed
1 task
jcommelin
jcommelin reviewed Oct 12, 2023
View reviewed changes
Mathlib/CategoryTheory/Triangulated/Pretriangulated.lean Outdated
instance : HasFiniteCoproducts C := hasFiniteCoproducts_of_has_binary_and_initial
instance : HasFiniteBiproducts C := HasFiniteBiproducts.of_hasFiniteProducts

lemma exists_iso_binaryBiproduct_of_dist_triangle (T : Triangle C) (hT : T ∈ distTriang C)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would use more camelCase, or is there already some convention that I missed?

Suggested change
lemma exists_iso_binaryBiproduct_of_dist_triangle (T : Triangle C) (hT : T ∈ distTriang C)
lemma exists_iso_binaryBiproduct_of_distTriangle (T : Triangle C) (hT : T ∈ distTriang C)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had some hesitation here. We also have many lemmas like rot_of_dist_triangle. Should we also rename these as rot_of_distTriang, etc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed rot_of_dist_triangle in #7643, and this lemma is now exists_iso_binaryBiproduct_of_distTriang.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Oct 12, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 13, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 18, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@joelriou joelriou added awaiting-review awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review labels Oct 18, 2023
@joelriou joelriou added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 18, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 20, 2023
bors bot pushed a commit that referenced this pull request Oct 20, 2023
@joelriou
feat: pretriangulated categories have finite biproducts (#7626)
54f4b74
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: pretriangulated categories have finite biproducts [Merged by Bors] - feat: pretriangulated categories have finite biproducts Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@bors bors bot deleted the triangulated-binary-biproducts branch October 20, 2023 15:15
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title [Merged by Bors] - feat: pretriangulated categories have finite biproducts [Merged by Bors] - [Merged by Bors] - feat: pretriangulated categories have finite biproducts Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelriou @leanprover-community-mathlib4-bot @jcommelin