Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: exactness of short complexes in concrete categories #8060

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: exactness of short complexes in concrete categories #8060

wants to merge 7 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Oct 31, 2023 •
edited
Loading

@joelriou joelriou added the t-category-theory Category theory label Oct 31, 2023
@joelriou joelriou mentioned this pull request Oct 31, 2023
Open
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Oct 31, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

jcommelin
jcommelin reviewed Nov 1, 2023
View reviewed changes
Mathlib/Algebra/Homology/ShortComplex/ConcreteCategory.lean Outdated

section abelian

variable [Abelian C] [(forget₂ C Ab).Additive] [(forget₂ C Ab).PreservesHomology]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the full force of abelian categories here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Indeed, [Preadditive C] and [HasZeroObject C] are sufficient here.

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 2, 2023
@joelriou joelriou added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 2, 2023
jcommelin
jcommelin approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 3, 2023
bors bot pushed a commit that referenced this pull request Nov 3, 2023
@joelriou
feat: exactness of short complexes in concrete categories (#8060)
8ddc254
@bors bors
Copy link

bors bot commented Nov 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: exactness of short complexes in concrete categories [Merged by Bors] - feat: exactness of short complexes in concrete categories Nov 3, 2023
@bors bors bot closed this Nov 3, 2023
@bors bors bot deleted the shortcomplex_concrete branch November 3, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelriou @leanprover-community-mathlib4-bot @jcommelin